Wil Clouser [:clouserw] Reporter
	Description • 10 years ago

When an add-on is signed we'll discard the private key but we want to record the serial number in case we need to block the add-on in the future.  We should just stick this as a new column in the `files` table.  This bug is about:

* Adding the new column in the files table
* Getting the serial number after the signing (either out of the package or from Trunion - see the dependent bug for the Trunion API) and putting it in the table

	Olivier Meunier [:aspyrine]
	Comment 1 • 10 years ago

What is the length of the field in database?

	Wil Clouser [:clouserw] Reporter
	Comment 2 • 10 years ago

I'd make it a varchar(255)

	Mathieu Agopian [:magopian] Assignee
	Comment 3 • 10 years ago

I don't see anything related to a serial number in the https://wiki.mozilla.org/AMO/SigningService/API page, am I missing something?

Is it the PKCS#7 signature returned by trunion? The value in the following json: {"zigbert.rsa": "MIIKfQYJKoZIhvcNAQcCoIIKbjCCCmoCAQExCzAJBgUrDgMCGgUAMAsGCSq...=="} ?

	Mathieu Agopian [:magopian] Assignee
	Comment 4 • 10 years ago

Created https://github.com/mozilla/signing-clients/issues/10

	Mathieu Agopian [:magopian] Assignee
	Comment 5 • 10 years ago

PR https://github.com/mozilla/olympia/pull/430

	Mathieu Agopian [:magopian] Assignee
	Comment 6 • 10 years ago

Fixed in https://github.com/mozilla/olympia/pull/430