Closed
Bug 1070195
Opened 10 years ago
Closed 10 years ago
Camera app kgsl memory growth during storing video thumbnails in 2.1
Categories
(Firefox OS Graveyard :: Stability, defect, P1)
Tracking
(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: tkundu, Assigned: djf)
References
Details
(Whiteboard: [caf priority: p1])
Attachments
(2 files)
(deleted),
text/x-github-pull-request
|
wilsonpage
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details |
(deleted),
text/x-github-pull-request
|
tkundu
:
feedback+
|
Details |
+++ This bug was initially created as a clone of Bug #1069534 +++ STR: 1) Open camcorder and record 30 videos (each video duration is 5secs) . We can see a linear kgsl growth within 5mins : kgsl memory after opening camcorder app : $adb shell cat /sys/class/kgsl/kgsl/page_alloc 5488640 kgsl memory after recording one video: adb shell cat /sys/class/kgsl/kgsl/page_alloc 23048192 kgsl memory after recording multiple videos: adb shell cat /sys/class/kgsl/kgsl/page_alloc 34996224 We need a similar fix mentioned in bug 1069534 Comment 6
Reporter | ||
Updated•10 years ago
|
Summary: b2g process memleak in 2.1 → Camera app kgsl memory growth during storing video thumbnails in 2.1
Reporter | ||
Comment 1•10 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.1?
Reporter | ||
Comment 2•10 years ago
|
||
Putting NI on you as you have helped us in 1064126 on 2.0
Flags: needinfo?(dflanagan)
Reporter | ||
Updated•10 years ago
|
Whiteboard: [caf priority: p1][CR 726725] → [caf priority: p1]
Updated•10 years ago
|
blocking-b2g: 2.1? → 2.1+
Reporter | ||
Comment 3•10 years ago
|
||
I am also seeing that following leaks by trying STR from Comment 0 . 1) camera app VSS is increasing(it reached from 100MB to 200MB) 2) Total ION memory has has jumped from 48MB to 139MB just after recording 1 video using Camera. 3) ION memory usage increases from 139MB to 155MB (Total ION 155MB http://pastebin.mozilla.org/6554078) if we keep repeating STR from Comment 0 4) kgsl memory growth mentioned in Comment 0. There may be multiple issues which is causing this leak. But getting a fix from gaia camcorder code (see bug 1069534 Comment 6) may help us to see what is next step here. Device used : msm8926 with 1GB memory.
Assignee | ||
Comment 4•10 years ago
|
||
I can't reproduce the bug on my 512mb Flame running master, but here's a patch that does the same thing we did for the Video app in bug 1069534
Attachment #8492443 -
Flags: review?(wilsonpage)
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 5•10 years ago
|
||
Tapas, Does this fix the bug for you?
Attachment #8492447 -
Flags: feedback?(tkundu)
Comment 6•10 years ago
|
||
Comment on attachment 8492443 [details]
patch for master
Looks fine, one tiny weeny nit.
Attachment #8492443 -
Flags: review?(wilsonpage) → review+
Reporter | ||
Comment 7•10 years ago
|
||
(In reply to David Flanagan [:djf] from comment #4) > Created attachment 8492443 [details] > patch for master > > I can't reproduce the bug on my 512mb Flame running master, but here's a > patch that does the same thing we did for the Video app in bug 1069534 Could you please re-base your patch for FFOS v2.1 ?
Flags: needinfo?(dflanagan)
Reporter | ||
Comment 8•10 years ago
|
||
Please ignore my Comment 7. It was my misunderstand !
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 9•10 years ago
|
||
Review comment addressed and patches updated. It is purely an indentation issue, so it won't affect the outcome of any testing. I'll wait to land this until I hear the results of Tapas's test run.
Assignee: nobody → dflanagan
Reporter | ||
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
Comment 10•10 years ago
|
||
David -- we should get this fixed in 2.0 as well. Considering the change does not look risky and fixes a leak which customers will definitely run into.
Reporter | ||
Comment 11•10 years ago
|
||
Comment on attachment 8492447 [details]
patch vor v2.1
Please land this fix for 2.1. We also want to see this is fixed in v2.0
Attachment #8492447 -
Flags: feedback?(tkundu) → feedback+
Flags: needinfo?(dflanagan)
Reporter | ||
Comment 12•10 years ago
|
||
We are not seeing any memory growth from #1, #2 , #3 and #4 of comment 3 after landing fix from attachment 8492447 [details] in v2.1 .
Assignee | ||
Comment 13•10 years ago
|
||
Landed on master: https://github.com/mozilla-b2g/gaia/commit/3563ddca35a52e7a533dcfc7996e74b78c6e36c8 Landed on v2.1: https://github.com/mozilla-b2g/gaia/commit/b3f9b97d16a1ab55f80239d63c1a85c3da3d39ad
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
Flags: needinfo?(dflanagan)
Resolution: --- → FIXED
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8492443 [details] patch for master Bhavana: this is a low-risk patch that CAF would like to have us uplift to 2.0. It mirrors a 2.0+ Video app patch (bug 1064126) that landed in 2.0 last week. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): not a regression [User impact] if declined: memory leaks when recording multiple videos with the camera app [Testing completed]: verified by CAF [Risk to taking this patch] (and alternatives if risky): not risky at all. All this patch does is set a canvas element size to zero after we are done using it so that the image memory it uses can be reclaimed more quickly. We landed a similar 2.0+ fix for the Video app a few weeks ago. [String changes made]: none.
Attachment #8492443 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
blocking-b2g: 2.1+ → 2.0+
Updated•10 years ago
|
Attachment #8492443 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Assignee | ||
Comment 15•10 years ago
|
||
Uplifted to v2.0: https://github.com/mozilla-b2g/gaia/commit/0658006be8a00fdb5931ee15a0aa353a3ab231ba
Comment 16•10 years ago
|
||
Merged t v2.0m: https://github.com/mozilla-b2g/gaia/commit/0658006be8a00fdb5931ee15a0aa353a3ab231ba
status-b2g-v2.0M:
--- → fixed
Updated•10 years ago
|
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•