Closed
Bug 107021
Opened 23 years ago
Closed 10 years ago
followup work on nsIFrame clean up
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: cathleennscp, Unassigned)
References
Details
we're taking the performance boosts from bug 104336
quote from dbaron's comment in bug 104336
>
> Further cleanup that should happen after this lands:
>
> Make nsIFrame not inherit from nsISupports (but still have QI).
>
> Make nsRuleNode::Transition return its result.
> Make nsIStyleContext::GetRuleNode return its result. (?)
>
> Make nsIFrame::SetParent take an |nsIFrame*| (look ma, no const!).
>
> Removing many of the |nsresult| return types.
>
Updated•23 years ago
|
Target Milestone: --- → mozilla1.1
Comment 1•22 years ago
|
||
->Misc Code
Assignee: attinasi → misc
Component: Layout → Layout: Misc Code
QA Contact: petersen → nobody
dbaron, do you want to do an nsISupports superclass with QI only that we can use
in nsIFrame and elsewhere? It doesn't sound hard. I could do it instead if you
prefer.
Comment 3•22 years ago
|
||
I think it would be nice, although the XPCOM folks probably wouldn't want it to
be a superclass of nsISupports itself.
I'm not sure if we can use it for nsIFrame and nsIView unless it's a superclass
of nsISupports. For nsIView at least, we need to make it the type of private
data for nsIWidget, which is sometimes an nsISupports thing and sometimes a
view. For nsIFrame, some places use XPCOM iterators on nsIFrames.
Updated•21 years ago
|
Target Milestone: Future → ---
Updated•15 years ago
|
Assignee: layout.misc-code → nobody
QA Contact: nobody → layout.misc-code
Comment 6•10 years ago
|
||
The things listed in comment 0 have been fixed in other bugs.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
Assignee | ||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•