Closed
Bug 1070457
Opened 10 years ago
Closed 10 years ago
"Assertion failure: mDriver->mAudioStream || aOperation == INIT (No audio stream !)" when no audio output device is installed
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla36
Tracking | Status | |
---|---|---|
firefox33 | --- | unaffected |
firefox34 | --- | fixed |
firefox35 | --- | fixed |
firefox36 | --- | fixed |
People
(Reporter: jruderman, Assigned: jesup)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files, 1 obsolete file)
(deleted),
text/html
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
roc
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
On fuzzer-win1, simply creating an AudioContext hits a fatal assert:
Assertion failure: mDriver->mAudioStream || aOperation == INIT (No audio stream !), at c:\builds\moz2_slave\m-cen-w32-d-000000000000000000\build\content\media\GraphDriver.cpp:460
The tooltip in the system tray says "No Audio Output Device is installed". Which makes sense, because fuzzer-win1 is more like a server than a workstation.
Regression from bug 1062293?
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Bughunter has seen this over 13000 times on 1290 urls for Aurora and Nightly on Windows VMs without audio on 32bit WinXP, Win7 and 64bit Win7. To confirm Jesse's diagnosis, the logs show:
Could not get default audio endpoint.
Could not get device.
[3928] WARNING: Could not create a cubeb stream for MediaStreamGraph, falling back to a SystemClockDriver: file c:\mozilla\builds\nightly\mozilla\content\media\GraphDriver.cpp, line 580
Assertion failure: mDriver->mAudioStream || aOperation == INIT (No audio stream !)
I don't crash with an opt Nightly build on an example url http://grooveshark.com/#%21/tribaltech nor on Jesse's testcase. This is the top crasher for Bughunter right now. Can we remove this assertion if it isn't meaningful?
Flags: needinfo?(padenot)
OS: Mac OS X → All
Hardware: x86_64 → All
Comment 3•10 years ago
|
||
Yes, we can downgrade this to a NS_WARNING or something. The code will do the right thing automatically.
Flags: needinfo?(padenot)
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8504843 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8504844 [details] [diff] [review]
downgrade assertion about cubeb audiostreams to a warning
trivial patch to downgrade the MOZ_ASSERT per padenot
Attachment #8504844 -
Flags: review?(roc)
Attachment #8504844 -
Flags: review?(roc) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 9•10 years ago
|
||
This has totally annihilated the assertion on Nightly! May I please have it on Aurora and Beta as well?
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8504844 [details] [diff] [review]
downgrade assertion about cubeb audiostreams to a warning
Approval Request Comment
[Feature/regressing bug #]: bug 848954
[User impact if declined]: assertions/crashes in test
[Describe test coverage new/current, TBPL]: current orange; gone in nightly now
[Risks and why]: No risk; debug-only change
[String/UUID change made/needed]: none
Attachment #8504844 -
Flags: approval-mozilla-beta?
Attachment #8504844 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox33:
--- → unaffected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
Comment 11•10 years ago
|
||
Comment on attachment 8504844 [details] [diff] [review]
downgrade assertion about cubeb audiostreams to a warning
Beta+
Aurora+
Attachment #8504844 -
Flags: approval-mozilla-beta?
Attachment #8504844 -
Flags: approval-mozilla-beta+
Attachment #8504844 -
Flags: approval-mozilla-aurora?
Attachment #8504844 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 12•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•