We should simplify the input[type=range] pseudo elements styling for these reasons : - Less override needed by web authors - Prettier styling Here's the changes I'm suggesting : - Replace the background-image on ::-moz-range-thumb with a simple background-color color - Remove the border on ::-moz-range-track

I should have before-after screens after I build Firefox today (gonna take me ~2 hours)

Comment on attachment 8492770 [details] [diff] [review] Patch v1 I'll defer to jwatt on this review, since he designed this control, and has thought more about its non-native styling than I have. :)

(In reply to Tim Nguyen [:ntim] from comment #2) > I should have before-after screens after I build Firefox today (gonna take > me ~2 hours) Tim, were you going to attach those screenshots?

Here you go :)

Comment on attachment 8492770 [details] [diff] [review] Patch v1 r+ if you strengthen the border of the thumb. It is too light/thin, I think.

(I already thought the existing styling of the thumb was a bit faint on a white background for people with poor vision.)

Thanks for the review ! Does this look better ?

Comment on attachment 8493904 [details] Thumb darker border That's probably just about good enough. Thanks.

With color changes.

(looks like "r=dholbert" stuck around in the commit message for the final patch version -- should've been "r=jwatt". I don't particularly mind, since the patch *does* have r+, and anyone who's curious about the changeset will end up here and see the correct reviewer anyway. But do keep that in your mental checklist when addressing review comments & reuploading patches in the future.)

(In reply to Daniel Holbert [:dholbert] from comment #12) > (looks like "r=dholbert" stuck around in the commit message for the final > patch version -- should've been "r=jwatt". > > I don't particularly mind, since the patch *does* have r+, and anyone who's > curious about the changeset will end up here and see the correct reviewer > anyway. But do keep that in your mental checklist when addressing review > comments & reuploading patches in the future.) Ah, sorry, completely forgot I put dholbert here. I'll keep this in mind next time :)