Closed
Bug 1071029
Opened 10 years ago
Closed 10 years ago
'contextmenu' events in Marionette are missing pageX and pageY values
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
If you long-press on an element on a b2g device, the resulting 'contextmenu' event has 'pageX' and 'pageY' properties which are missing on the same event generated via Marionette. Although I can't find documentation for the pageX/pageY properties, reading the code, it looks like the clientX/Y and screenX/Y properties are similarly missing. Ideally, the Marionette event would have all three pairs so that it matched the behaviour of normal user-generated events in Gecko.
Comment 2•10 years ago
|
||
Comment on attachment 8493153 [details] [diff] [review] Fix contextmenu events in marionette Review of attachment 8493153 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! This looks great.
Attachment #8493153 -
Flags: review?(mdas) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•10 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/5d90266605a1
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d90266605a1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
This is a testonly bug and no user-facing changes are made. Nothing to be verified here.
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•