User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.120 Safari/537.36 Steps to reproduce: Repro frequency: 100% 1. Open the Video app 2. Select a video file 3. Tapping on right '...' button on top right of the preview window to open the action menu. 4. <ISSUE> When opening the action menu, there is just one cancel button and no other items on the screen. See attached: Bug_[Video] cancel button.jpg ---------------------------------------------------------------- * Enviromental Variables: Device : Flatfish 2.2 Master B2G : 2.2.0.0-prerelease Gaia : 8a052654136ea6e9d48d154a9e9716da37d36d1c Gecko : 93e8d332916f46266b333a7bede2b5f78c255cd1 BuildID : 20140922011806 Version : 35.0a1

https://github.com/mozilla-b2g/gaia/blob/8e8cffcc37335048848ece8c1d7dae1a3020c752/apps/video/style/video_tablet.css#L265 due to: .layout-list .single-delete-button, .layout-list .single-share-button, .layout-list .single-info-button { display: none; }

I don't understand the purpose of these rules. Can you do modification to fix it or guidance here?

(In reply to YF (Yang) from comment #2) > I don't understand the purpose of these rules. Can you do modification to > fix it or guidance here? Sorry but I'm not sure what these rules are for either =/ I think we need a Video peer to advise as to whether they are required. As they are only within the tablet style-sheet, I'd assume it's safe to remove them if it improves the tablet experience.

I don't have the context for these rules. NI for John: can you explain the purpose of [1] in video_table.css? Note that lines 265-267 were added by [2] [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/video/style/video_tablet.css#L261-L269 [2] https://github.com/mozilla-b2g/gaia/commit/8e8cffcc37335048848ece8c1d7dae1a3020c752

According to the original UX/Visual spec of tablet, we don't need to show the buttons at header bar which is the the line 265-267 means. We only show them at fullscreen mode. And after the fast forward and rewind landing, we changed the logic and shows them when user taps the "..." button. So, we don't need to hide those three buttons, in list mode. Basically, we should tap the "..." button in fullscreen mode, we should see those three buttons. If not, we may need to check the default visibility of those three buttons. I would suggest to remove the those three rules because there may be some misunderstood about the state of .layout-list in tablet.

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #5) > Basically, we should tap the "..." button in > fullscreen mode, we should see those three buttons. Typo here.. The correct version: Basically, when we tap the "..." button in fullscreen mode, we should see those three buttons.

Comment on attachment 8526934 [details] patch This version looks good to me. Since I had transferred to another project for a few months, I request another video peer to review this patch. Thanks.

The changes look good. Ordinarily I would test the changes but in this case I cannot as I don't have access to a tablet. I'm assuming the changes have been tested and do fix the issue.

Comment on attachment 8526934 [details] patch See comment 10

Firefox OS is not being worked on