Hey Pavel, Can you help update the settings icon that appears when offline in RB search? It looking blurry at the moment. Can you update with the images here on box? https://mozilla.box.com/s/1d71do1j3q3upy309dcx Thanks!

Hey Eric, you can test 1x and 1.5x versions with this patch ... but we need @2x and @2.25x versions because the images in box are @2x=50x50(need to be 48x48) and @2.25=56x56 (need to be 54px)

Hey Pavel, I've tested on the flame and the icons seems to be cut off on the top and bottom. Can you take a look? Also, I've updated the icons for 2x and 2.25x

Hey Pavel, I've made some changes to the spec for this. Here are the changes: - Updated Icon (Will attach, can you update to use asset sizes - they are too big at the moment) - Make string the same size as the RB search suggestions - String should be in the same position as the RB search suggestion (but in white) - Setting icons should be vertically centered with the string Can you update this items? Let me know if you have any questions!

Comment on attachment 8496986 [details] patch for Gaia/master Taking off UI-Review Patch because of the changes. Pavel, can you reflag me when it's ready? Thanks!

Hey Eric, PR is updated with all suggestions which we discussed by email. can you ui-r? this one?

(In reply to Pavel Ivanov [:ivanovpavel] from comment #8) > Hey Eric, > > PR is updated with all suggestions which we discussed by email. > can you ui-r? this one? Hey Pavel it's looking good, but can you move the settings icon 1px up? I think it should be good after this little change :). Thanks!

Hey Eric, can you check the PR and if it's OK ui-r+ please :)

Comment on attachment 8498850 [details] patch for Gaia/master Thanks Pavel, looks good now!

Comment on attachment 8498851 [details] 2014-10-02-16-12-10.png Clearing the review flag since I've already reviewed the patch.

I left a comment on GitHub, but this looks fine to me. Not sure why integration tests are failing, I re-triggered the job. Please wait for green before landing.

Hey Eric, what do you think about https://github.com/mozilla-b2g/gaia/pull/24701

(In reply to Pavel Ivanov [:ivanovpavel] from comment #14) > Hey Eric, > > what do you think about https://github.com/mozilla-b2g/gaia/pull/24701 Looks good to me, thanks Pavel!

See attachment 2014 [details]-09-30-13-34-35.png This is not acceptable in a quality device. Please fix

Thanks all :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/22c898034764ee36673c713995f13245b9df8816

[Blocking Requested - why for this release]: re-noming for uplift based on comment 16 This is a risk-less change that improves the quality of the device. Without the update the ui looks sloppy. Work is completed and already landed to master. Gregor, any chance we can uplift? It's a small change, but cleans the RB search screen which is a feature. Thanks!

We can't block on it that late in the game but please request uplift approval.

Comment on attachment 8498850 [details] patch for Gaia/master Raising flag for Pavel since he has limited connectivity. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): New 2.1 feature [User impact] if declined: Without the patch the design looks sloppy and unrefined [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low risk if any [String changes made]: None

v2.1: https://github.com/mozilla-b2g/gaia/commit/84a6a449eac7e10e3c7bf7cd464c5d803b34d4e6

This issue has been successfully verified on Flame 2.1: Gaia-Rev 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6 Build-ID 20141125001201 Version 34.0 Device-Name flame FW-Release 4.4.2 This issue has been successfully verified on Flame 2.2: Gaia-Rev 824a61cccec4c69be9a86ad5cb629a1f61fa142f Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d Build-ID 20141125040209 Version 36.0a1 Device-Name flame FW-Release 4.4.2