Kevin Grandon :kgrandon Assignee
	Description • 10 years ago

      No description provided.

	Kevin Grandon :kgrandon Assignee
	Comment 1 • 10 years ago

Hey Ben - Could you give this a review if you have time? This makes it so we use the system bookmark logic instead of the browser logic. Thanks!

	Ben Francis [:benfrancis]
	Comment 2 • 10 years ago

Comment on attachment 8493882 [details]
Github pull request

Thanks Kevin! I don't think I should review this though.

Adding Chris for the homescreen part and Etienne for the system part.

	Kevin Grandon :kgrandon Assignee
	Comment 3 • 10 years ago

(In reply to Ben Francis [:benfrancis] from comment #2)
> Comment on attachment 8493882 [details]
> Thanks Kevin! I don't think I should review this though.

If you don't feel comfortable reviewing I think that's ok, though I think it's ok for me to ask you for review because I'm a peer on both modules? Sorry if I'm mistaken, but that was my understanding.


(In reply to Ben Francis [:benfrancis] from comment #2)
> Adding Chris for the homescreen part and Etienne for the system part.

Sounds good to me, but since this is a small test only patch - if one of you guys gets to it, feel free to clear the review for the other person to save some review cycles if you are comfortable with it. Thanks!

	Chris Lord [:cwiiis]
	Comment 4 • 10 years ago

Comment on attachment 8493882 [details]
Github pull request

Assuming the tests still work, this looks good to me.

	Kevin Grandon :kgrandon Assignee
	Comment 5 • 10 years ago

In master: https://github.com/mozilla-b2g/gaia/commit/e96369cc5252b624ca9bc490d16b7545796349ac

	Carsten Book [:Tomcat]
	Comment 6 • 10 years ago

sorry had to revert this checking for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48753239&tree=B2g-Inbound

	Zac C (:zac)
	Comment 7 • 10 years ago

Re the Gip failures, they are not test failures but Marionette is picking up on exceptions in the gecko.log and interpreting them as failures.

Thus you should be able to replicate this by just starting up b2g and observing the logcat (or gecko.log in the case of this, desktopb2g).

	Ben Francis [:benfrancis]
	Comment 8 • 10 years ago

(In reply to Kevin Grandon :kgrandon from comment #3)
> If you don't feel comfortable reviewing I think that's ok, though I think
> it's ok for me to ask you for review because I'm a peer on both modules?
> Sorry if I'm mistaken, but that was my understanding.

That's an interesting theory, let's take it to the mailing list!

	Kevin Grandon :kgrandon Assignee
	Comment 9 • 10 years ago

(In reply to Carsten Book [:Tomcat] from comment #6)
> sorry had to revert this checking for test failures like
> https://tbpl.mozilla.org/php/getParsedLog.php?id=48753239&tree=B2g-Inbound

Ah crud. I think I was debugging some local changes and accidentally squashed them into the commit when changing the reviewer name heh. Re-submitting now, sorry about this.

	Kevin Grandon :kgrandon Assignee
	Comment 10 • 10 years ago

Re-submitting pull request and will wait for gaia-try. Carrying review.

	Kevin Grandon :kgrandon Assignee
	Comment 11 • 10 years ago

In master: https://github.com/mozilla-b2g/gaia/commit/75df85cbcf0440a59602c01a65ece6aca61f6952
v2.1 (a=testonly): https://github.com/mozilla-b2g/gaia/commit/9e28b533bc4f66bb8c440baacd7d807c50fee646