We need more/better ways to output debug information for the settings API. - Switch debug messages to being pref'd on/off instead of requiring compiled in change - Add memory reporters to SettingsManager/SettingsRequestManager/SettingsService

I know :bent isn't a fan of debug functions that always run while possibly having arguments that require resolution, but I really need a way to be able to tell QA and reporters to turn on debug messages without having to kick out a new build.

Comment on attachment 8494268 [details] [diff] [review] Patch 1 (v1) - Add pref to turn on/off settings debug messages Review of attachment 8494268 [details] [diff] [review]: ----------------------------------------------------------------- Your other option is to do something like: let DEBUG = Services.prefs.getBoolPref("dom.mozSettings.debug"); function debug() { dump("-*- SettingsManager : " + aMsg + "\n") } and to replace all your calls to debug(...) by DEBUG && debug(...)

Ok yeah maybe I shouldn't code while as tired as I am right now. 'cause that was nice and obvious. Implemented Fabrice's suggestion and lopped like 40k off the patch.

Comment on attachment 8494279 [details] [diff] [review] Patch 1 (v2) - Add pref to turn on/off settings debug messages Review of attachment 8494279 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/app/b2g.js @@ +507,4 @@ > > // WebSettings > pref("dom.mozSettings.enabled", true); > +pref("dom.mozSettings.debug", false); Hrm, I hate to quibble, but shouldn't this be s/debug/logging/ ? ::: dom/settings/SettingsManager.js @@ +4,4 @@ > > "use strict"; > > +const DEBUG = Services.prefs.getBoolPref("dom.mozSettings.debug"); So, doing things this way means that you have to restart before the pref change takes effect... Is that what you want, or should we try to live-update it?

Dup'd and done better by bug 1106896