Closed
Bug 1071878
Opened 10 years ago
Closed 10 years ago
Sites without favicons should show an empty rectangle rather than a globe
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Showing a globe would be strange given our doorhanger solution (bug 1071267).
|
Assignee | |
Comment 1•10 years ago
|
||
Alternatively, maybe we can symlink R.drawable.favicon?
Attachment #8494171 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8494171 [details] [diff] [review]
Put an empty rectangle for websites without favicons on new tablet
Review of attachment 8494171 [details] [diff] [review]:
-----------------------------------------------------------------
Cool.
::: mobile/android/base/favicons/Favicons.java
@@ +400,5 @@
> + // Decode the default Favicon ready for use. We'd preferably override the drawable for
> + // different screen sizes, but since we need phone's default favicon on tablet (in
> + // ToolbarDisplayLayout), we can't.
> + final int defaultFaviconDrawableID =
> + isNewTabletEnabled ? R.drawable.favicon_none : R.drawable.favicon;
I wonder if favicon_none should actually be named new_tablet_default_favicon?
Attachment #8494171 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8494171 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8494863 -
Flags: review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•