Closed
Bug 1072062
Opened 10 years ago
Closed 10 years ago
SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
New build warning with clang on mozilla-inbound:
{
media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: warning: '&&' within '||' [-Wlogical-op-parentheses]
if (!mCencDefaultSize && !mCencInfoCount || mCencOffsets.isEmpty()) {
~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ~~
media/libstagefright/frameworks/av/media/libstagefright/SampleTable.cpp:595:27: note: place parentheses around the '&&' expression to silence this warning
}
|
Assignee | |
Comment 1•10 years ago
|
||
Here's the trivial fix suggested by the compiler. Edwin, does this parenthesization match the way you intended the logic to be evaluated?
Comment on attachment 8494187 [details] [diff] [review]
fix v1
Review of attachment 8494187 [details] [diff] [review]:
-----------------------------------------------------------------
Yep, that's the one I meant. Thanks for doing that.
Attachment #8494187 -
Flags: review?(edwin) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•