(no longer active) Assignee
	Description • 10 years ago

      No description provided.

	(no longer active) Assignee
	Comment 3 • 10 years ago

Comment on attachment 8494983 [details] [diff] [review]
Build some Firefox OS specific DOM code in unified mode; r=baku

https://tbpl.mozilla.org/?tree=Try&rev=0660aac161d3

	Andrea Marchesini [:baku]
	Comment 4 • 10 years ago

Comment on attachment 8494983 [details] [diff] [review]
Build some Firefox OS specific DOM code in unified mode; r=baku

Review of attachment 8494983 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/gonk/SmsService.cpp
@@ +14,5 @@
>  
>  uint32_t
>  getDefaultServiceId()
>  {
> +  const char* kPrefRilNumRadioInterfaces = "ril.numRadioInterfaces";

static ?

@@ +41,5 @@
>    mRil = do_GetService("@mozilla.org/ril;1");
>    NS_WARN_IF_FALSE(mRil, "This shouldn't fail!");
>  
>    // Initialize observer.
> +  const char* kObservedPrefs[] = {

static ?

::: dom/mobilemessage/ipc/SmsIPCService.cpp
@@ +79,5 @@
>  
>  uint32_t
>  getDefaultServiceId(const char* aPrefKey)
>  {
> +  const char* kPrefRilNumRadioInterfaces = "ril.numRadioInterfaces";

static

@@ +113,5 @@
>  }
>  
>  SmsIPCService::SmsIPCService()
>  {
> +  const char* kObservedPrefs[] = {

static

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/5293979e38c6