Closed
Bug 1072779
Opened 10 years ago
Closed 10 years ago
We should show screenshot overlay before opening an app.
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: evanxd)
References
Details
Attachments
(1 file)
When attention screen comes, we are not able to show the screenshot anymore when the attention screen terminates.
And this is because visibility manager will tell appWindowManager to hide active app window and the app window will call this.setVisible(false) in hidewindow handler.
Now setVisible is decoupled from screenshot so we should call this._showScreenshotOverlay() (and check this.isActive() to avoid mem issue) in the hidewindow handler.
|
Assignee | |
Comment 1•10 years ago
|
||
Thanks, Alive.
I'll take a look.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → evanxd
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8504481 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25112
Hi Alive,
Could you give feedbacks for the patch?
I'll update the unit tests once the patch is OK.
Thanks.
Attachment #8504481 -
Flags: feedback?(alive)
|
Reporter | |
Comment 4•10 years ago
|
||
Comment on attachment 8504481 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25112
The questioning part is the asynchronous getScreenshot will not give you screenshotBlob, could you explain why that?
Attachment #8504481 -
Flags: feedback?(alive)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8504481 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25112
Hi Alive,
I updated the patch.
Could you help to review it.
Thanks.
Attachment #8504481 -
Flags: review?(alive)
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8504481 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25112
We need test and r+ if you are done.
Attachment #8504481 -
Flags: review?(alive) → review+
|
|
Reporter | |
Updated•10 years ago
|
Summary: We should show screenshot overlay in hidewindow handler. → We should show screenshot overlay before opening an app.
|
|
Assignee | |
Comment 7•10 years ago
|
||
Alive, thanks for the review.
|
|
Assignee | |
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•