Closed
Bug 1073210
Opened 10 years ago
Closed 9 years ago
Remove dangerous public destructor of MiscContainer
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
INVALID
People
(Reporter: mccr8, Assigned: anujagarwal464)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mccr8
:
feedback-
|
Details | Diff | Splinter Review |
This class is defined in content/base/src/nsAttrValueInlines.h. Removing the public destructor could be tricky because sometimes this struct is refcounted and sometimes it isn't.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → anujagarwal464
Attachment #8496008 -
Flags: feedback?(continuation)
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8496008 [details] [diff] [review] bug1073210.diff Review of attachment 8496008 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/src/nsAttrValue.cpp @@ -282,2 @@ > if (otherCont->IsRefCounted()) { > - delete ClearMiscContainer(); I don't think this is going to work. If you look at ClearMiscContainer(), it does a bunch of stuff. This whole MiscContainer thing is very odd and may require some serious reworking.
Attachment #8496008 -
Flags: feedback?(continuation) → feedback-
Comment 4•9 years ago
|
||
MiscContainer is no longer refcounted.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•