Closed Bug 1073611 Opened 10 years ago Closed 10 years ago

[System] software home button regressions with fullscreen_layout

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rnicoletti, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(3 files)

While investigating bug 1062022, I noticed there have been some regressions regarding the behavior of the software home button. There are two separate regressions in the behavior (two separate builds producing different/incorrect behavior). The incorrect behavior is the background of the software home button becomes transparent instead of black and the software home button is not hidden when entering fullscreen (mozRequestFullScreen). Oldest build where behavior is correct: Gaia 6cb5e0100d70313e4922c8d34bf20dcdd66ef616 Gecko https://hg.mozilla.org/mozilla-central/rev/2db5b64f6d49 BuildID 20140912040204 Version 35.0a1 Build where swhb background becomes transparent: Gaia b72909030e214175144342f7e5df7e88a2b52fd4 Gecko https://hg.mozilla.org/mozilla-central/rev/2db5b64f6d49 BuildID 20140912040204 Version 35.0a1 Build where swhb does not get hidden when in fullscreen: Gaia e5da0e462e51cf7f56963e87deb845f87a3a1cf4 Gecko https://hg.mozilla.org/mozilla-central/rev/d070787de8f7 BuildID 20140913160203 Version 35.0a1 I have verified it is the Gaia revision that is responsible for the changes in behavior. For example, after flashing gecko and gaia with buildId 20140913160203 (where swhb does not hide when in fullscreen), I flashed only gaia from buildId 20140912040204 and the swhb does hide in fullscreen).
To test software home button fullscreen_layout functionality: 1) Apply the patch from bug 1055198 2) Flash your desired build 3) Install video app 4) 'adb shell setprop ro.moz.has_home_button 0' 5) stop and start b2g
Summary: [System] software home button regressions → [System] software home button regressions with fullscreen_layout
Attached image swhb transparent - landscape (deleted) —
Attached image swhb transparent - portrait (deleted) —
Attached image swhb not hidden in fullscreen (deleted) —
[Blocking Requested - why for this release]: This blocks Tako's ability to make the video app effectively show and hide the SHB with an API call. We can't ship 2.1 without this ability.
blocking-b2g: --- → 2.1?
Broken feature.
blocking-b2g: 2.1? → 2.1+
Whiteboard: [systemsfe]
The issue where fullscreen layout apps no longer have the dark background for SHB is caused by bug 1059967. https://github.com/mozilla-b2g/gaia/commit/b570198ace4bcb53f1d4ea5884894bcffa936c8d I'll file a new bug for that. Should be an easy fix.
Depends on: 1074569
The issue where SHB does not hide when request fullscreen in fullscreen_layout apps was caused by bug 1064595. https://github.com/mozilla-b2g/gaia/commit/582298623311fea69a961443f9c58589ee24c45c I'll file a new bug for that one shortly.
Depends on: 1074580
Assignee: nobody → mhenretty
Blocks: 1055198
This has become more of a meta bug without any code, so I'm removing the blocking flag and closing since it's blockers are in master.
Status: NEW → RESOLVED
blocking-b2g: 2.1+ → ---
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: