Closed
Bug 1073692
Opened 10 years ago
Closed 10 years ago
Search suggestions popup on about:home/about:newtab should show each result according to its text direction
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
dir is set on the table, which means that the first result in the popup determines the text direction of the whole popup. So if the popup contains both RTL and LTR text, one or the other will be shown incorrectly.
Instead dir should be set on each row.
Assignee | ||
Updated•10 years ago
|
Summary: Search suggestions popup on about:home/about:new should correctly show each result according to its text direction by setting dir attribute on table rows → Search suggestions popup on about:home/about:newtab should show each result according to its text direction
Updated•10 years ago
|
Attachment #8496249 -
Flags: review?(ehsan.akhgari) → review+
Updated•10 years ago
|
Iteration: 35.2 → 35.3
Updated•10 years ago
|
Keywords: checkin-needed
Comment 1•10 years ago
|
||
Needs a Try run and a patch with commit information included.
Keywords: checkin-needed
Comment 2•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
You need to log in
before you can comment on or make changes to this bug.
Description
•