Closed Bug 1073717 Opened 10 years ago Closed 2 years ago

[Web Notifications] Add support for "silent" notifications on desktop

Tracking

()

Status:

RESOLVED FIXED

Milestone:

110 Branch

Tracking Flags:

Tracking

Status

firefox110

---

fixed

People

(Reporter: mikehenrty, Assigned: MattN)

References

(Blocks 3 open bugs,
URL
)

Details

(Whiteboard: [systemsfe])

Attachments

(4 files, 3 obsolete files)

silent_notifications.patch 10 years ago Robert Bindar (deleted), patch	baku : review+	Details \| Diff \| Splinter Review
gaia_silent_notifications 10 years ago Robert Bindar (deleted), text/x-github-pull-request		Details
silent_notifications.patch 10 years ago Robert Bindar (deleted), patch	mikehenrty : review+	Details \| Diff \| Splinter Review
Bug 1073717 - [Web Notifications] Add support for "silent" notifications on macOS. r=mstange 3 years ago Matthew N. [:MattN] (deleted), text/x-phabricator-request		Details
Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell 3 years ago Matthew N. [:MattN] (deleted), text/x-phabricator-request		Details
Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify. r=stransky 3 years ago Matthew N. [:MattN] (deleted), text/x-phabricator-request		Details
Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz 3 years ago Matthew N. [:MattN] (deleted), text/x-phabricator-request		Details

Comment hidden (obsolete)

Now that we have the ability to specify notification behavior options, let's support a "completelySilent" behavior that allows the user to have both no sound and no vibration. Currently, we don't allow notifications to specify no vibration (see [1]) for fear they may unwittingly get a completely silent notification. This behavior allows them explicitly specify complete silence.

1.) http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2014-August/297575.html

Anthony Ricaud (:rik)

Updated

•

10 years ago

Blocks: 1073020

Anthony Ricaud (:rik)

Updated

•

10 years ago

Blocks: 1049479

Comment hidden (obsolete)

Robert Bindar

Comment 2

•

10 years ago

Attached file gaia_silent_notifications (obsolete) (deleted) — Details

Michael is there any way I can test whether a sound was played?

Attachment #8499520 - Flags: review?(mhenretty)

Comment hidden (obsolete)

Comment on attachment 8499517 [details] [diff] [review]
silent_notifications.patch

Review of attachment 8499517 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/Notification.webidl
@@ +68,5 @@
>  dictionary GetNotificationOptions {
>    DOMString tag;
>  };
>  
>  dictionary NotificationBehavior {

Would be nice if this dictionary was called 'MozNotificationBehavior'.
Can we do that? Or write a comment saying that this dictionary is a mozilla-only feature.

Comment hidden (obsolete)

We could do either of those 2, but I personally don't see the point of moz prefixing the dictionary providing that we prefixed the NotificationOptions property. A comment would make the things more clear for sure.

Comment hidden (obsolete)

A comment is enough.

Comment hidden (obsolete)

Comment on attachment 8501356 [details] [diff] [review]
silent_notifications.patch

Review of attachment 8501356 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure we get a green Try run before landing.

Comment hidden (obsolete)

Comment on attachment 8499520 [details]
gaia_silent_notifications

Looking good! I want to see some tests for it though :)

Sylvestre Ledru [:Sylvestre]

Comment 9

•

6 years ago

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Priority: P2 → P3

Sylvestre Ledru [:Sylvestre]

Comment 10

•

6 years ago

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Matthew N. [:MattN]

Assignee

Comment 11

•

5 years ago

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=679a9f27af26b404fc2edd3065ab4109185a87d5

Assignee: robertbindar → MattN+bmo

Blocks: 1335659

URL: https://notifications.spec.whatwg.org...

Status: NEW → ASSIGNED

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1505044

Matthew N. [:MattN]

Assignee

Updated

•

5 years ago

Attachment #8499520 - Attachment is obsolete: true

Matthew N. [:MattN]

Assignee

Updated

•

5 years ago

Attachment #8501356 - Attachment is obsolete: true

Matthew N. [:MattN]

Assignee

Comment 12

•

5 years ago

Test page: https://bugs.mattn.ca/w3c_notifications.htm

Matthew N. [:MattN]

Assignee

Updated

•

5 years ago

Type: defect → enhancement

doconno

Comment 13

•

4 years ago

I am use notification for the transit prediction website TransSee https://www.transsee.ca/ My notifications updates themselves every 10 seconds and would benefit from the silent option.

However I think the deeper problem is that when a notification is updated (by doing a showNotification with the same tag as a previous notification) Firefox is closing and opening a new notification rather then updating the existing notification like Chrome does. This can be seen in that fact that Firefox triggers the notificationclose event every time a notification is updated, unlike Chrome (which I had to work around).

bop

Comment 14

•

4 years ago

(In reply to Matthew N. [:MattN] from comment #11)

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

It also affects Android. Silent notifications shouldn't cause vibrations and lighting up of the screen.

Matthew N. [:MattN]

Assignee

Comment 15

•

3 years ago

(In reply to bop from comment #14)

(In reply to Matthew N. [:MattN] from comment #11)

I got annoyed at hearing the macOS notification sound every time Google Play Music played a new track (because I enabled notification to see the song name) so I'm taking this. I think it only affects macOS for now.

It also affects Android. Silent notifications shouldn't cause vibrations and lighting up of the screen.

This was implemented for Android in bug 1696145 but is currently limited to Nightly builds.

Severity: normal → N/A

Depends on: 1696145

Summary: [Web Notifications] Add support for "silent" notifications → [Web Notifications] Add support for "silent" notifications on desktop

Matthew N. [:MattN]

Assignee

•

3 years ago

Not that I know of!

Flags: needinfo?(agi)

switz213

Comment 22

•

3 years ago

Any word on merging this PR? Been waiting 5+ years for this, looks like the PR is ready to go.

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Comment 23

•

2 years ago

D119590 has been there over a year since accepted, any reason why it's not landing?

Flags: needinfo?(mozilla+bmo)

Matthew N. [:MattN]

Assignee

Comment 24

•

2 years ago

Only the macOS portion was accepted. I hadn't got around to re-testing the patches on Linux and Windows since I wrote these patches years ago. I rebased now and will try to test on Windows and Linux when I have a chance. If someone else has time to test and review them sooner then that would be great.

Phabricator Automation

Updated

•

2 years ago

Attachment #9230660 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. → Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=nalexander

Phabricator Automation

Updated

•

2 years ago

Attachment #9230662 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki

Phabricator Automation

Updated

•

2 years ago

Attachment #9230661 - Attachment description: WIP: Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify → Bug 1073717 - [Web Notifications] Add support for "silent" notifications with libnotify. r=stransky

Matthew N. [:MattN]

Assignee

Updated

•

2 years ago

Flags: needinfo?(mozilla+bmo)

Phabricator Automation

Updated

•

2 years ago

Attachment #9230662 - Attachment description: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz

Phabricator Automation

Updated

•

2 years ago

Attachment #9230662 - Attachment description: Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz → Bug 1073717 - [Web Notifications] Enable desktop support for "silent" notifications on Nightly r=masayuki

Phabricator Automation

Updated

•

2 years ago

Attachment #9230660 - Attachment description: Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=nalexander → Bug 1073717 - [Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell

Phabricator Automation

Updated

•

2 years ago

Pulsebot

Comment 25

•

2 years ago

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/9e5e59c9399b
[Web Notifications] Add support for "silent" notifications on macOS. r=mstange
https://hg.mozilla.org/integration/autoland/rev/cf0dac184d52
[Web Notifications] Add support for "silent" toast notifications on Windows. r=mhowell
https://hg.mozilla.org/integration/autoland/rev/f6c8c0c6f87b
[Web Notifications] Add support for "silent" notifications with libnotify. r=stransky
https://hg.mozilla.org/integration/autoland/rev/d2da482646eb
[Web Notifications] Enable desktop support for "silent" notifications on Nightly r=saschanaz

Matthew N. [:MattN]

Assignee

Updated

•

2 years ago

Blocks: 1809028

Norisz Fay [:noriszfay]

Comment 26

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9e5e59c9399b
https://hg.mozilla.org/mozilla-central/rev/cf0dac184d52
https://hg.mozilla.org/mozilla-central/rev/f6c8c0c6f87b
https://hg.mozilla.org/mozilla-central/rev/d2da482646eb

Status: ASSIGNED → RESOLVED

Closed: 2 years ago

status-firefox110: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 110 Branch

Kagami [:saschanaz] (they/them, PTO until 2023-09-10)

Updated

•

1 year ago

Blocks: 1844584

Component: DOM: Core & HTML → DOM: Notifications

You need to log in before you can comment on or make changes to this bug.