Rudy Lu [:rudyl] (inactive after 2015/7/3) Reporter
	Description • 10 years ago

This is a regression after bug 1065961 lands,
STR
===
1. Long press 'e' of English layout to show the alt char menu.
2. move to the last key of the lower row, i.e. "ë" (Don't move up to activate the upper row).
3. Move upwards

  Expected: the last key 'ɛ' would be highlighted.
  Actual: nothing happens.

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 1 • 10 years ago

I'll take this after I land bug 1044525 since resolution of this bug would be different with/without bug 1044525.

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 2 • 10 years ago

Hi Rudy,

Please review the patch.

From bug 1044525 and onwards, Our desired flow from user interaction ("raw" press event) onto target resolution and onto actual handling logics is: we should always try to resolve DOM elements [that user is interacting with] into target key objects as soon as possible; anything that doesn't have a target key object (which means it has no intended user-interactivity) should not propagate downstream.

Downstream handling logics should always try to handle key objects, with the exception of views, which are allowed to retrieve "visual elements" (I hope I have a more precise definition on this...) from the reverse map. Bug 1044525 has not dealt with this concept very clear-cut, and we'll manage remaining architecture issues in follow-up bugs.

	Rudy Lu [:rudyl] (inactive after 2015/7/3) Reporter
	Comment 3 • 10 years ago

Comment on attachment 8497257 [details]
Patch (PR @ GitHub)

r=me.
Thanks for your help!

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 4 • 10 years ago

Master: https://github.com/mozilla-b2g/gaia/commit/ec1b3b90248b5649aa5ab64cef171d3101f2834b

	Safwan Rahman (:safwan)
	Comment 5 • 10 years ago

It seems that The Patch affected badly flashfish Device!
See Bug 1075011

	John Lu [:mnjul][Please NI or I'll miss] Assignee
	Comment 6 • 10 years ago

(In reply to Safwan Rahman from comment #5)
> It seems that The Patch affected badly flashfish Device!
> See Bug 1075011

Bisect on bug 1075011 comment 1 says the bad comment is bug 1043959.