If you enter the search page from the browser you can see it in landscape mode. This is pretty useless since you can't see the search results. We should just disallow it since entering from the homescreen doesn't allow us to switch to landscape

[Blocking Requested - why for this release]:

Do we have UX spec for this?

Unless I'm mistaken, "no landscape" should be the spec. Flagging Francis, though.

Well the problem is that we need landscape otherwise it's extremely jarring to use the browser in landscape. You're browsing a site in landscape, then want to change URLs, and everything reverts to portrait? IMO - if there's a problem with the landscape UX, we should fix that.

I agree with Kevin landscape browsing then we should also support a landscape search app, but the current layout looks like it needs redesigning. First of all, it looks as if the keyboard is too big - please see the keyboard spec here: https://www.dropbox.com/s/ieklqdoljbxq5jj/FFOS_1.3_VsD_Refresh_Keyboard.key?dl=0 (pages 17 onwards) The search app layout also needs to be rethought. It seems as if we're wasting space at the top and the icons should probably be smaller with some padding on either side. Eric, is there a visual spec for this?

(In reply to Francis Djabri [:djabber] from comment #5) > I agree with Kevin landscape browsing then we should also support a > landscape search app, but the current layout looks like it needs > redesigning. > > First of all, it looks as if the keyboard is too big - please see the > keyboard spec here: > > https://www.dropbox.com/s/ieklqdoljbxq5jj/FFOS_1.3_VsD_Refresh_Keyboard. > key?dl=0 (pages 17 onwards) > > The search app layout also needs to be rethought. It seems as if we're > wasting space at the top and the icons should probably be smaller with some > padding on either side. Eric, is there a visual spec for this? We didn't have landscape in mind when creating the designs, but Kevin brings up a good point about the browser being jarring without it. I'll look into creating an updated visual spec today for it. Leaving need info on myself as a reminder.

Hi Carol, I wanted to get you involved in this bug since you own keyboard. If you look at the above comments you'll see that the keyboard takes up too much vertical space on landscape on the flame. Seems like it's not being resized correctly. Right now I think it's stretching to fit the space, which causes the height to be huge on wider devices because of the space that needs to be filled. What should happen is the keyboard should be sized up depending on device by 1.5x, 2x, 2.25x, etc. In the case of the flame it should be sized up by 1.5x which will give the correct height. After that the remaining width should be calculated with the top line keys. Space on screen divided by 10 (so each key becomes wider). Then the second and third line fits in between and etc. Do you know if any work is being done like this for the keyboard? Flagging Przemek as well in case he has anything to add!

I agree with Eric, but it's complicated so Carol if you have any questions feel free to message me.

Hi Gregor, I've attached a spec for landscape RB search. I've kept the changes simple with most being the same as portrait. Changes included increased left and right margins with 6 icons across (at the same size as portrait). Let me know if anything else is needed, thanks!

Thanks Eric! I'll see what we can do here, but I don't think we can do this for 2.1, possibly 2.2. Clearing the ni on Gregor for now.

Hi Eric, I agree with you that the keyboard takes up too much vertical space on landscape on the flame. I will adjust the height of the keyboard for landscape. But in this case, even after we decrease the height of the keyboard, I don't think it would help much for seeing the search result. They can only see the half circles from the first roll. One solution here is that users can eject the keyboard in order to see the icons. Thanks!

Taking to investigate what can be done from the search app side of things

This is probably more of a "gaia grid" issue, than an issue with the search app. I suppose we would need to change our calculations in grid_layout.js to make sure that things are the same size as portrait mode.

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1077391 for the fixes to the keyboard Without them then there isnt much to do, its only the very top of the icons that can be seen anyway, however may as well get gaia grid fixed early anyway Kevin what was your plan for the orientation support, should we give the grid an icon size we want to render at and support however many fits, or tell it how many rows we want? Feel free to steal if you think its best you work on that, otherwise need a little pointer into the best direction

(In reply to Dale Harvey (:daleharvey) from comment #14) > I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1077391 for the fixes > to the keyboard > > Without them then there isnt much to do, its only the very top of the icons > that can be seen anyway, however may as well get gaia grid fixed early anyway Well, there is a new spec to adhere to. The main work is making the gaia-grid fit more icons per row. > Kevin what was your plan for the orientation support, should we give the > grid an icon size we want to render at and support however many fits, or > tell it how many rows we want Yeah, I think passing in the number of columns for landscape might make sense here. I don't think we need to do anything more for orientation support though, it should already redraw on orientation change. > Feel free to steal if you think its best you work on that, otherwise need a > little pointer into the best direction I don't think I'll steal this for a few weeks, maybe Cristian would be interested in it as he did the original sizing logic? Adding a needinfo on him in case he wants to steal.

Hi Kevin, I am working in Firefox Loop Client now and I prefer that someone who is working on search/gaia grid/home can take it better than me

IF the plan is to set a configuration of the number of columns to show while rendering I can figure that out, but untaking while working on blockers

Also https://bugzilla.mozilla.org/show_bug.cgi?id=1052080 requires being able to configure the number of columns

Firefox OS is not being worked on