Closed
Bug 1074553
Opened 10 years ago
Closed 6 years ago
[e10s] make social iframes remote
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(e10slater)
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
e10s | later | --- |
People
(Reporter: mixedpuppy, Unassigned)
References
Details
(Whiteboard: sb-)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
social iframes are not remote, there is no reason they shouldn't be (other than a chunk of work to make it happen).
Reporter | ||
Updated•10 years ago
|
Blocks: e10s-social
Comment 1•10 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> social iframes are not remote, there is no reason they shouldn't be (other
> than a chunk of work to make it happen).
IIRC, there might also be some API issues - memory is vague, but I seem to recall there were at least some APIs we expose that are sync, and which couldn't be sync in that world.
(Not that that should stop us, but it might be worth investigating now so we can deprecate old stuff)
Updated•10 years ago
|
Reporter | ||
Comment 2•10 years ago
|
||
Reporter | ||
Comment 3•10 years ago
|
||
an actual patch rather than an empty patch :)
Attachment #8535714 -
Attachment is obsolete: true
Reporter | ||
Comment 4•9 years ago
|
||
Took another spin on this. The basic problem is the browser is never made visible if remote=true, and it seems there are assumptions in remote-browser that the browser is in a tab which would not be the case here.
Updated•9 years ago
|
Whiteboard: sb?
Comment 5•9 years ago
|
||
Is this likely to affect PanelFrame at any stage? We're currently only doing e10s for the conversation window since that's the high load one (and it was simpler/required for working with e10s).
We could do the panel, but our code/tests aren't going to work with that at the moment.
Reporter | ||
Comment 6•9 years ago
|
||
My first step would be share since that is 99% of socialapi usage. Given the problems I encountered with making the adjustment, I'm not sure how that will progress.
Updated•9 years ago
|
Whiteboard: sb? → sbwc1
Updated•9 years ago
|
Whiteboard: sbwc1 → sbwc2
Comment 7•9 years ago
|
||
The sandboxing team isn't going to block on this for the first roll out of a level 1 sandbox on Windows. (The first content sandbox that will roll out.) But we're going to block on it for other content sandboxes and the next windows sandbox milestone. Can you all get this prioritized into your queues so it gets fixed fairly soon?
Flags: needinfo?(standard8)
Comment 8•9 years ago
|
||
(I think we would want this fix in release by spring 2017.)
Comment 9•9 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #7)
> The sandboxing team isn't going to block on this for the first roll out of a
> level 1 sandbox on Windows. (The first content sandbox that will roll out.)
> But we're going to block on it for other content sandboxes and the next
> windows sandbox milestone. Can you all get this prioritized into your queues
> so it gets fixed fairly soon?
Filed bug 1261350
Flags: needinfo?(standard8)
Comment 10•8 years ago
|
||
Mark, can we close this out as wontfix? Or is this still valid for some social services we support?
Flags: needinfo?(markh)
Comment 11•8 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #10)
> Mark, can we close this out as wontfix? Or is this still valid for some
> social services we support?
Shane is probably in a better position to answer this.
Flags: needinfo?(markh) → needinfo?(mixedpuppy)
Reporter | ||
Comment 12•8 years ago
|
||
The share panel is still not remote. If the new share button in the activitystream experiment were to replace it we wouldn't need to do anything.
Flags: needinfo?(mixedpuppy)
Comment 14•6 years ago
|
||
SocialAPI was removed from Firefox 57 and is no longer available in any current release.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•