We are planning on making the screen reader public for 2.2 which means we can enable the setting menu for/during the 2.2 sprint.

My first Q is what should I develop with. So far I've been building the full stack using git for Flatfish and Flame but guess this is just gaia so can just fork that?

The settings menu visibility depends on this setting: 'accessibility.screenreader-show-settings'. Currently, by default, the setting is present in the developer setting as a check box. Since the plan is to get it out of the developer preview for 2.2 we can get rid of this setting entirely (in the developer section). The accessibility settings screen should also have the screen reader section visible by default. In the markup that is controlled by 'data-show-name' attribute. We can get rid of that as well. The screen reader settings screen (inside accessibility settings) also has a visibility attribute (same as above) that depends on the setting. That should be removed as well. apps/system/js/accessibility.js has a listener that sets 'accessibility.screenreader-show-settings' permanently the first time the screen reader is enabled. That should be removed as well since the panel will be visible by default. We have Gaia UI tests (python) that set the setting we are getting rid so they would also need to be updated.

(In reply to Steve Lee from comment #1) > My first Q is what should I develop with. So far I've been building the full > stack using git for Flatfish and Flame but guess this is just gaia so can > just fork that? Yes you only need a Gaia repo for that. You can still test it on device though, by running 'make install-gaia' (shallow instal).

* I notice that the 'Screen reader started" speech is clobbered by the checkbox enable state. * Need to add UI test for the confirm dialog - I add as much as I could right now. * I did not the the test as the node script mozilla-download does not download B2G. It quietly does nothing and I've not managed to figure out why.

Comment on attachment 8498801 [details] PR Hi Steve, most of the changes look good, but it's a little difficult to read with other changes present. Could you rebase your pull request so it only has your changes and in a single commit ? Thanks!

> Hi Steve, most of the changes look good, but it's a little difficult to read > with other changes present. Could you rebase your pull request so it only > has your changes and in a single commit ? Thanks! Yura. OMG, of course. I don't know what happened there!? My git foo is compromised. I did merge upstream but that should have been on master only. The whole point of creating that feature branch was to avoid such problems. Plus I looked at the PR after that merge (must have been cached). Will rebase and reapply for a review. Sorry!

Comment on attachment 8498801 [details] PR The PR is now clear and minus all those other files. My apologies

Comment on attachment 8498801 [details] PR Looks really good! Just a couple of comments in the PR. Thanks!

Thanks. I added a few responses in the PR and will make the changes

Comment on attachment 8498801 [details] PR I made the changes, squashed and pushed, Also commented on the tests.

Comment on attachment 8498801 [details] PR Talked about the improvements in IRC + added some comments in the PR.

Hi Steve, I wondering if you would have to wrap this bug up? We are about to finish most of the outstanding apps in Gaia and are ready to have the SR visible by default.

Hey Yura. Thanks forthe nudge. I spoke to Eitan at CSUN and got the impression that this might not be needed anymore as the settings had got reorganised? What do you think? I can schedule time to get done for end of next week.

Comment on attachment 8687017 [details] [gaia] yzen:bug1074906 > mozilla-b2g:master Updated original PR (rebase + some nits)

Comment on attachment 8687017 [details] [gaia] yzen:bug1074906 > mozilla-b2g:master Looks good. One nit is after screen reader is enabled, the gaia-switch is not selectable. But its gaia-switch's accessibility issue and can be solved in a separate bug.

(In reply to Fred Lin [:gasolin] from comment #17) > Comment on attachment 8687017 [details] > [gaia] yzen:bug1074906 > mozilla-b2g:master > > Looks good. > > One nit is after screen reader is enabled, the gaia-switch is not > selectable. But its gaia-switch's accessibility issue and can be solved in a > separate bug. Yeah once we update gaia-switch to the latest version from gaia-components it will be fixed.

@yura I stopped work on this as II understood from Eitan that the next version of FirefoxOS made it unnecessary. ISthat OK or is there somehting I still should do. I'd have to set up my dev env from scratch.

(In reply to Steve Lee from comment #20) > @yura I stopped work on this as II understood from Eitan that the next > version of FirefoxOS made it unnecessary. ISthat OK or is there somehting I > still should do. I'd have to set up my dev env from scratch. Hi Steve, nothing to worry about. Your patch was almost ready so I just updated it to latest master and committed as is.

Thanks \0/ I have an a11y patch in firefox OS. Wh00t