Closed
Bug 1074993
Opened 10 years ago
Closed 10 years ago
(app-grouping) Make group headers match updated spec
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Currently the hit targets for the group header and font-sizes conform to an older version of the spec. We should update them to match the new one.
Assignee | ||
Comment 1•10 years ago
|
||
Based on bug 1074798, so that needs to be reviewed/merged before reviewing this.
Attachment #8497649 -
Flags: review?(kgrandon)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8497649 [details]
Update group headers to match spec
A review from either of you would be great
Attachment #8497649 -
Flags: review?(crdlc)
Comment 3•10 years ago
|
||
Comment on attachment 8497649 [details] Update group headers to match spec Please once bug 1074798 is in master ask me for a review. thanks a lot
Attachment #8497649 -
Flags: review?(crdlc)
Comment 4•10 years ago
|
||
Comment on attachment 8497649 [details] Update group headers to match spec I'm assuming this is for the single commit here: https://github.com/Cwiiis/gaia/commit/02ae23ac18ae492bff1c1d9e646d298c04ef5829 The main reason I can't R+ this is that the @2.0x.png images are named wrongly. These should be @2x instead. Fix that and R+.
Attachment #8497649 -
Flags: review?(kgrandon)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8497649 [details]
Update group headers to match spec
Fixed 2x image naming, assuming r+.
Attachment #8497649 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/08ecd85443b56211d65f60eb094242cf5f87ca96
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [systemsfe]
Updated•10 years ago
|
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•