Comment on attachment 8498213 [details] [diff] [review] Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View Review of attachment 8498213 [details] [diff] [review]: ----------------------------------------------------------------- Yep. ::: mobile/android/base/tabs/TabsGridLayout.java @@ +100,2 @@ > super.bindView(view, tab); > + view.close.setVisibility(View.VISIBLE); Why do you need to set the close button's visibility here? Is it because the shared layout file has visibility GONE by default?

Good spot - it doesn't seem to be there for a reason and things look good without it there. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=289ccaff48d8

Comment on attachment 8498213 [details] [diff] [review] Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View Review of attachment 8498213 [details] [diff] [review]: ----------------------------------------------------------------- Go.