Closed
Bug 1075986
Opened 10 years ago
Closed 10 years ago
Add MOZ_OVERRIDE in SurfaceCache.cpp
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
DUPLICATE
of bug 923302
People
(Reporter: dholbert, Unassigned)
References
Details
Noticed two functions that (currently) want a MOZ_OVERRIDE annotation, in SurfaceCache.cpp:
> 209 class SurfaceCacheImpl MOZ_FINAL : public nsIMemoryReporter
> 210 {
[...]
> 395 NS_IMETHOD
> 396 CollectReports(nsIHandleReportCallback* aHandleReport, nsISupports* aData,
> 397 bool aAnonymize)
> 398 {
and:
> 441 struct MemoryPressureObserver : public nsIObserver
> 442 {
[...]
> 445 NS_IMETHOD Observe(nsISupports*, const char* aTopic, const char16_t*)
> 446 {
http://mxr.mozilla.org/mozilla-central/source/image/src/SurfaceCache.cpp?rev=d42f046984ce
(I'd just go ahead and fix these, but I don't want to bitrot seth's patches in bug 923302 & maybe other related bugs; hence, marking as depending on bug 923302, to remind me or seth or someone to fix these after that patch is in.)
Reporter | ||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Comment 1•10 years ago
|
||
This change is now integrated into the patch for bug 923302.
Comment 2•10 years ago
|
||
Bug 923302 landed with the MOZ_OVERRIDEs added in.
Not entirely sure what status I should use for this, marking as a duplicate for now.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 3•10 years ago
|
||
Thanks! I'd forgotten about this bug. "duplicate" makes sense to me.
You need to log in
before you can comment on or make changes to this bug.
Description
•