Closed
Bug 107627
Opened 23 years ago
Closed 23 years ago
Flash page loading flash image out of place
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: tracy, Assigned: jst)
References
()
Details
(Keywords: regression, smoketest, top100, Whiteboard: [HAVE FIX])
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
seen onbuilds:
windows mozilla 2001-10-30-03-trunk
linux mozilla 2001-10-30-11-trunk
linux commercial 2001-10-30-11-trunk
mac mozilla 2001-10-30-08-trunk
mac osx mozilla 2001-10-30-05-trunk
- go to the above page and choose "Flash"
notice the resulting page loads with the flash image above left of the expected
area (which is the now empty rectangle in center page)
I checked this against 4.7 on linux and windows and the image loads where
expected. I've also try some other flash pages with the builds listed and they
seem to work fine also.
bug 107659 and bug 107649 reported today. dups?
undersized flash and flash pushing content out of place is all over the place.
http://www.nettavisen.no (near top of page)
substories at http://www.aftenposten.no have right side too wide when there's
flash there
http://www.macromedia.com - click link "if you have the flash 5 player click here"
Is macromedia top100?
Comment 4•23 years ago
|
||
*** Bug 107649 has been marked as a duplicate of this bug. ***
Comment 5•23 years ago
|
||
win98: 2001102903 (2001-10-29-11-trunk) is ok, misplaced&-scaled flash things
with 2001103003 (2001-10-30-03-trunk)
All plugins are broken. They scale wrong or clip wrong.
Tested quicktime and realplayer, and in bug 107705 reporter tells Acrobat reader
plugin is broken.
Adding some keywords. This breaks Disney, Apple, CNN.. all of them. Upping
severity - but this should really be a blocker..
Severity: major → critical
Keywords: regression,
top100
Comment 7•23 years ago
|
||
WFM Win93 build ID 2001102903
Comment 8•23 years ago
|
||
can we narrow it down to any checkins between 10-29 build and 10-30 builds?
Comment 9•23 years ago
|
||
if its layout related check these:
Throwing out possible regression bugs:
bug 107453
Hyatts: nsIFrame Checkin v3.190
or the new grid code?
or bug 97630.
-dennis
Comment 10•23 years ago
|
||
My pull wasn't showing this so I'm repulling and building now....
Comment 11•23 years ago
|
||
linux/crossover/QT show the new MP3 player commercial at apple.com with text:
Say Hell
1000 songs
Comment 12•23 years ago
|
||
confirming on W2K. Many top100 sites look really bad, upgrading to blocker.
Okay, let's see what I can back out.
Severity: critical → blocker
Priority: -- → P1
Target Milestone: --- → mozilla0.9.6
Comment 13•23 years ago
|
||
It's not the patch from bug 97630. I will try backing out bug 107453 next.
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
*** Bug 107804 has been marked as a duplicate of this bug. ***
Comment 16•23 years ago
|
||
throwing out another possible layout one:
just read some comments on bug 56117 - patch for the style system. Could this
be related to layout of content seen here? Not sure, just by reading the lingo
there.
Comment 17•23 years ago
|
||
I don't think it's what I checked in since the page
http://www.tombraider.com/flash.html has the image centered (as expected, I
presume) in my tree from yesterday that has all the changes I checked in.
Also, adding smoketest keyword since the beard thinks this should hold the tree
closed, so it should be on the blocker list.
Keywords: smoketest
Comment 18•23 years ago
|
||
I've been told I might need to have a plugin installed to see this problem. Any
ideas which plugin?
Comment 19•23 years ago
|
||
Flash (npswf32.dll) ... and also try http://www.macromedia.com
Assignee | ||
Comment 20•23 years ago
|
||
All mine, caused by the fix for 107453, patch coming up.
Assignee: av → jst
Keywords: smoketest
Assignee | ||
Comment 21•23 years ago
|
||
Assignee | ||
Comment 22•23 years ago
|
||
I flunked when comginging the embed elemnt code with the shared leaf element
code, I lost the attribute mapping code :-(
The attached patch fixes the problem. Reviews?
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Comment 23•23 years ago
|
||
Comment on attachment 55957 [details] [diff] [review]
Give embed elements back their attribute mapping code...
Looks good. r=bzbarsky
Attachment #55957 -
Flags: review+
Comment 24•23 years ago
|
||
Comment on attachment 55957 [details] [diff] [review]
Give embed elements back their attribute mapping code...
sf=sfraser
Attachment #55957 -
Flags: superreview+
Assignee | ||
Comment 25•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 26•23 years ago
|
||
Tracy, please verify this fix in the next build.
thanks.
Keywords: smoketest
Comment 27•23 years ago
|
||
*** Bug 107856 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 28•23 years ago
|
||
verified with respin on linux commercial 2001-10-31-13-trunk
Status: RESOLVED → VERIFIED
Comment 29•23 years ago
|
||
*** Bug 108807 has been marked as a duplicate of this bug. ***
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•