Comment on attachment 8498841 [details] [diff] [review] v1 r=me

FWIW, I think it'd be better to pass around an nsIDocument rather than an nsIPrincipal here. So that we could get both the principal and the loadgroup from that. And so that we could pass that document to NS_NewChannel when creating network channels. But that could certainly be done as a separate bug.

I think that means you just volunteered to review, right?

Comment on attachment 8499416 [details] [diff] [review] Pass the document to TX_LoadSheet v1 Review of attachment 8499416 [details] [diff] [review]: ----------------------------------------------------------------- Please also replace txCompileObserver::mLoadGroup with a txCompileObserver::mLoadingDocument. And remove txCompileObserver::mCallerPrincipal as it's unused (and should not be used). ::: dom/xslt/xslt/txMozillaStylesheetCompiler.cpp @@ +532,5 @@ > return NS_ERROR_DOM_BAD_URI; > } > > nsRefPtr<txCompileObserver> observer = > + new txCompileObserver(aProcessor, loadGroup); I think we should be passing the document rather than the loadgroup here too.

Comment on attachment 8499416 [details] [diff] [review] Pass the document to TX_LoadSheet v1 Review of attachment 8499416 [details] [diff] [review]: ----------------------------------------------------------------- I guess this patch is actually fine as-is. But we should get rid of the loadgroup and change it to a document as well. Though if you want to do that separately that's ok. Sorry this took a while, I had to swap back this code into my brain.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1da35b1d5663 https://hg.mozilla.org/integration/mozilla-inbound/rev/3e40213d4a21 Changed to pass the document to txCompileObserver.

https://hg.mozilla.org/mozilla-central/rev/1da35b1d5663 https://hg.mozilla.org/mozilla-central/rev/3e40213d4a21