Closed Bug 1076909 Opened 10 years ago Closed 10 years ago

pdf.js should handle the registerAddonHistogram() argument order changing

Categories

(Firefox :: PDF Viewer, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: gfritzsche, Unassigned)

References

Details

(Whiteboard: [pdfjs-c-integration][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/5428)

+++ This bug was initially created as a clone of Bug #1076897 +++ In bug 1069953, i want to make the min, max & bucket_count args of registerAddonHistogram() optional. The pdf.js version we ship in Nightly should handle this before we land that change. This means changing the signature from: registerAddonHistogram(in ACString addon_id, in ACString name, in uint32_t min, in uint32_t max, in uint32_t bucket_count, in unsigned long histogram_type); ... to: [optional_argc] void registerAddonHistogram(in ACString addon_id, in ACString name, in uint32_t min, in uint32_t max, in uint32_t bucket_count, in unsigned long histogram_type); in unsigned long histogram_type, [optional] in uint32_t min, [optional] in uint32_t max, [optional] in uint32_t bucket_count);
Priority: -- → P1
Whiteboard: [pdfjs-c-integration]
No longer blocks: 1069953
Depends on: 1069953
Status: NEW → RESOLVED
Closed: 10 years ago
Depends on: 1110260
Resolution: --- → FIXED
Whiteboard: [pdfjs-c-integration] → [pdfjs-c-integration][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/5428
You need to log in before you can comment on or make changes to this bug.