Closed
Bug 1077032
Opened 10 years ago
Closed 10 years ago
about:home favicon in the new tablet UI is poor
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 affected)
RESOLVED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
firefox35 | --- | affected |
People
(Reporter: aaronmt, Assigned: mcomella)
References
Details
Attachments
(5 files, 2 obsolete files)
See screenshot.
I only see this in the new tablet UI.
--
Nexus 7 (Android L Preview)
Nightly (10/02)
Reporter | ||
Comment 1•10 years ago
|
||
Second screenshot showing both selected and non-selected tabs
Assignee | ||
Comment 2•10 years ago
|
||
Maybe because we're scaling to a different size?
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment 3•10 years ago
|
||
FWIW, strictly speaking, this is the about:home favicon, not the default one. In the new UI, the default favicon is the 'empty square' icon.
Summary: Default favicon in the new tablet UI is poor → about:home favicon in the new tablet UI is poor
Comment 4•10 years ago
|
||
Mike, I think we'll need a new_tablet_favicon_search.
Assignee | ||
Comment 5•10 years ago
|
||
Anthony, can I get a version of the favicon_search icon [1] for tablets? (16dp x 16dp, I believe)
[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-mdpi/favicon_search.png
Flags: needinfo?(alam)
Assignee | ||
Comment 7•10 years ago
|
||
The new icon didn't seem to work.
Assignee | ||
Comment 8•10 years ago
|
||
Updated•10 years ago
|
Flags: needinfo?(alam)
Comment 9•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #5)
> Anthony, can I get a version of the favicon_search icon [1] for tablets?
> (16dp x 16dp, I believe)
>
> [1]:
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/
> drawable-mdpi/favicon_search.png
I don't think we use 16px favicons anywhere in the native UI. I think the smallest we use is 32px.
Also, the aboutHome.xhtml file does not have a favicon linked in it's source:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutHome.xhtml
Comment 10•10 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #8)
> Created attachment 8499937 [details]
> WIP screenshot
Yeah, that still looks rough.
(In reply to Mark Finkle (:mfinkle) from comment #9)
> I don't think we use 16px favicons anywhere in the native UI. I think the
> smallest we use is 32px.
Maybe is this the issue here?
Flags: needinfo?(alam) → needinfo?(michael.l.comella)
Assignee | ||
Comment 11•10 years ago
|
||
Seems I just changed the wrong value when I initially set this up.
Attachment #8499936 -
Attachment is obsolete: true
Attachment #8499937 -
Attachment is obsolete: true
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 12•10 years ago
|
||
It looks pretty good on my N7 even without the new icons.
Attachment #8509967 -
Flags: review?(lucasr.at.mozilla)
Comment 13•10 years ago
|
||
Comment on attachment 8509967 [details] [diff] [review]
Fix blurry about:home icon in new tablet tab strip
Review of attachment 8509967 [details] [diff] [review]:
-----------------------------------------------------------------
Yep.
Attachment #8509967 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•