Closed
Bug 1077206
Opened 10 years ago
Closed 10 years ago
Weird display of GB and Li
Categories
(Taskcluster :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: jlal)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
It looks like: unknown(GB Li)
Ideally these should just be GB and Li, but maybe GB(GB) Li(Li) could work if that's all we can do.
Reporter | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
This is how we report data to treeherder:
https://github.com/taskcluster/taskcluster-treeherder/blob/master/treeherder/handlers.js#L193-L448
@jeads,
Can you say a few words about the following properties, we're pretty much guessing at this point.
- group_name
- group_symbol
- product_name
Must we provide all of these properties? (I don't think we mind, we just don't know what treeherder expects).
Also while I'm asking can you explain what the valid properties for "option_collection" is?
Can we set any property we want dynamically? Can values only be `true`?
Flags: needinfo?(jeads)
Comment 3•10 years ago
|
||
Examples of groups & symbols for buildbot jobs:
https://github.com/mozilla/treeherder-service/blob/master/tests/etl/test_buildbot.py#L332
Currently jobs that don't belong to a group are defined as:
'group_name': 'unknown',
'group_symbol': '?'
However I think this would be better as the empty string (I'd like to move buildbot jobs away from unknown/"?")
Comment 4•10 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #3)
> However I think this would be better as the empty string (I'd like to move
> buildbot jobs away from unknown/"?")
Bug 1065137 is filed for this. For that bug (and also this one) we may need to fix handling in both the service and the UI, since iirc "?" etc is hardcoded (yey)
Assignee | ||
Comment 5•10 years ago
|
||
Ed provided the information joans was looking for the "looking weird" part for GB is going to be fixed here https://bugzilla.mozilla.org/show_bug.cgi?id=1078019 and I will take this on to hack something so linters look okay
Assignee: nobody → jlal
Flags: needinfo?(jeads)
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
The symbols used are normally only a couple of characters long, and typically sentence case rather than all capitals.
If these are going to appear alongside the sheriffed jobs at some point, we may wish to coordinate with the group names used by the buildbot jobs, but for now doesn't matter :-)
Updated•9 years ago
|
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Comment 8•9 years ago
|
||
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•