Jordan Santell [:jsantell] [@jsantell] Reporter
	Description • 10 years ago

      No description provided.

	Jordan Santell [:jsantell] [@jsantell] Reporter
	Comment 1 • 10 years ago

Should not be selectable when timeline actor (Gecko < 35) does not exist.

	Victor Porof [:vporof][:vp] Assignee
	Comment 2 • 10 years ago

Needs a test.

	Victor Porof [:vporof][:vp] Assignee
	Comment 3 • 10 years ago

Has test.

	Jordan Santell [:jsantell] [@jsantell] Reporter
	Comment 4 • 10 years ago

Comment on attachment 8544836 [details] [diff] [review]
v2

Review of attachment 8544836 [details] [diff] [review]:
-----------------------------------------------------------------

so little code. love it.

::: browser/locales/en-US/chrome/browser/devtools/profiler.properties
@@ +107,5 @@
>  
>  # LOCALIZATION NOTE (recordingsList.saveDialogAllFilter):
>  # This string is displayed as a filter for saving a recording to disk.
>  recordingsList.saveDialogAllFilter=All Files
> +

nit space

	Victor Porof [:vporof][:vp] Assignee
	Comment 5 • 10 years ago

SUCH GREEN https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=476eeb84011b

	Victor Porof [:vporof][:vp] Assignee
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/fx-team/rev/5032626927f2

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/5032626927f2

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 8 • 10 years ago

Seems like this might be worth noting once it ships.

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 9 • 10 years ago

Note that visibility of this tool depends on bug 1123815. This can't be relnoted until then. It also may not make sense to relnote this separately from the new performance tool.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 10 • 9 years ago

Release Note Request (optional, but appreciated)
[Why is this notable]:  Nifty new view for performance tool. I think it's worth a new note.
[Suggested wording]: Add flamechart view to Details view in new performance tool
[Links (documentation, blog post, etc)]: 

Jordan, is there anything up that we could link to that explains this tool or shows how it works?

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 11 • 9 years ago

Setting firefox-relnote flag to 40+ as Liz just added this to the release notes on nucleus.

	Jordan Santell [:jsantell] [@jsantell] Reporter
	Comment 12 • 9 years ago

Will is working on some docs for the new tool for the June 2nd release, but don't think the flame graph stuff is done yet: https://developer.mozilla.org/en-US/docs/Tools/Performance__

(And I think this will replace the current performance page for tools)

Pinging Will

	Will Bamberg [:wbamberg]
	Comment 13 • 9 years ago

jsantell, yes, I am aiming for the June 2nd date, but should have some stuff for you to look at by the end of next week.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 14 • 9 years ago

I could swear this just said Firefox 40. But looks like it went out in 37. I'm removing the release note!

	Jordan Santell [:jsantell] [@jsantell] Reporter
	Comment 15 • 9 years ago

It technically landed in 37, but always behind a pref or build flag; 40.1 dev ed will be the first real "public" release