Closed
Bug 1078232
Opened 10 years ago
Closed 10 years ago
(App-grouping) Show empty group name edit hint text
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S6 (10oct)
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Whoops, forgot to fill out the description... The visual spec shows a text hint for group names that appears only in edit mode when the group name is empty.
Assignee | ||
Comment 2•10 years ago
|
||
Whoever gets there first, it's quite a small change. I had to take some licence with the text-shadow as the spec doesn't fully describe it and the values given certainly don't match the screenshots. Looks ok to me, but we can address it in follow-up if it isn't.
Attachment #8500393 -
Flags: review?(kgrandon)
Attachment #8500393 -
Flags: review?(crdlc)
Comment 3•10 years ago
|
||
Comment on attachment 8500393 [details]
Show empty group name edit hint text
LGTM, I left a comment. thanks a lot
Attachment #8500393 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks, addressed and merged: https://github.com/mozilla-b2g/gaia/commit/414c8d891dc86ffb295d2f3206373268e984e795
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Attachment #8500393 -
Flags: review?(kgrandon)
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S6 (10oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•