Closed Bug 107848 Opened 23 years ago Closed 23 years ago

Wrong tab is closed when last but one tab is closed

Categories

(SeaMonkey :: Tabbed Browser, defect)

Product:
SeaMonkey
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.1alpha

People

(Reporter: aleksander.adamowski, Assigned: jag+mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Use current tab when click wasn't on a tab
(deleted), patch
caillon
: review+
bugs
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
Build ID: 2001103108, but also seen in previous builds for some time now.

To reproduce:
Quite hard to reproduce, I couldn't determine exactly what steps are needed to
reproduce. However, you may try:
1. Open several tabs
2. Open a different page in each tab
3. Do usual browsing (maybe some "Open in New Tab" operations are required)
4. Close all tabs one by one by right-clicking on them and selecting "Close Tab"
After last but one tab is closed often the wrong one is closed (not the one we
right-clicked, but the other one).

BTW. Can this bug be related to bug 107845?
One more thing.
After the last but one tab gets closed, and we stay with non-tabbed browser
window, try to immediately open a new empty tab.
You should end up with 3 tabs instead of 2! 
The tab that had previously been closed actually was still there and now reappears.
I discovered this independently, but find it very easy to replicate on a Mac
(using the drop-down menu for all tab operations):

1.Go to a page with lots of hot links
2.Open two of the links by "Open In New Tab" -- there are now three tabs open
3.Close the rightmost tab -- there are now two tabs open
4.Close the rightmost tab (this was the middle one until step 3)
5.Note that the tab just "closed" did not close -- it appears that the other
(leftmost) tab was closed instead, and there are no tabs showing
6.Open another tab
7.Note that there are now three tabs open -- the one just opened and both of the
tabs that were open previous to step 4

The really annoying part of this is that (if you don't know the trick of opening
the tab at step 6) you've lost the original page you started with, and there's
no way back to it.
I've seen this too when surfing Google, keeping the main search results page, 
then tabbing to look at each result.  Sometimes closing the tab closes the wrong 
tab content and leaves tabbed mode.

When I reopen a tab in the same window, the old content is still there in a tab. 
i.e. going from no tabs to two, I get three. 
looks like another dupe of bug 106385
I've seen this before in the previous nightlies, but it seems to have been fixed
somehow in the latest nightlies. I am currently using build 2001112508 on Win2K
and this has not occured so far. I just hope it got fixed period. =)
still seeing this in build 2001112603 win32
Using Ctrl+F4 on win32 (the shortcut key to close a tab) may also show the bug.

I'm using Mozilla 0.9.6 (build 2001112009).
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1
*** Bug 106385 has been marked as a duplicate of this bug. ***
*** Bug 113239 has been marked as a duplicate of this bug. ***
QA Contact: blakeross → sairuh
Still happening on 12-6 build 2001120603

- Open window
- Open tab from url link right-click context menu
- Close tab from tab context menu
- Tab continues to be dislplayed, window is hidden

*** if you open a new tab, correct display is restored, but problem continues.
I think the checkin for bug 114043 could change the behavior for this bug also
(see my comment in bug 102551).

Unfortunatly I am currently not able to reproduce this bug. Can anybody confirm
(with a build 2001120721 or more recent) that "Close tab" now (sometimes) simply
does not work and produces the exception in the JavaScript Console:

Error: aTab has no properties
Source File: chrome://global/content/bindings/tabbrowser.xml#tabbrowser.removeTab()
Line: 2

but never closes the wrong tab or hides the tabbar ?
I'm still using 0.9.6, but it seems quite reproducible (on linux) if you linger
over "Close tab" for a while before pressing the left mouse button.

Also, if one lingers over close tab on not the next-to-last tab, and then
presses the left button, the tab won't close.
From continuing to use Mozilla and tabs, I wonder if this problem relates to
making sure the tab is selected.  I think just one click doesn't do it - I am
clicking multiple times on the tab before I right-click and select Close Tab,
and it seems to fix the problem.

Just anecdotal, but I thought I'd mention it for the programmer to check out.
Steve
This may be a different bug, but I am still seeing sometimes when I left click
on the last tab, right-click and select close, nothing happens.

This is Build 2001121003, win98se
(left-clicking twice on the tab before right-click seems to help close the tab
normally most times)
*** Bug 115814 has been marked as a duplicate of this bug. ***
Reassigning to new component owner.
Assignee: hyatt → jaggernaut
Status: ASSIGNED → NEW
I don't know if this is the same thing, but on win32 .9.8, it is impossible to
close the first tab.  sometimes clicking on the close button will close the
other tabs instead of the first one.
Got your comments.  I'm also on win98SE.  This has been WORKSFORME for me for a
while.  Are you perhaps using an old build?  Also, I think it would help if you
get real specific about steps leading up to and each key/mousestroke when you
try to close the tab.

I do notice that the pop-up right-click tab menu moves up about 1/2 inch if I
hover too long, after about .5 seconds.  I believe this is not desired behavior.
*** Bug 130201 has been marked as a duplicate of this bug. ***
This seems to be related... I'm using v1rc2 on W2K, and I cannot close the first
tab. Also, sometimes, when I have two tabs, and I have "hide tabbar when 1 tab"
on, the tabbar will be hidden when I attempt to close the first tab.
I found that I can consistently reproduce this if I right click "close tab" on
the bottom part of the tab, it seems not to happen if I click the top part.
I have been playing with this bug a bit and can reproduce it at will.  I am
running 1.0 (Build ID: 2002052918) under Linux.

1) open a couple of tabs

2) notice the bar that runs the width of the window and 'connects' to the tab in
front?  That's the region where the bug exists.

3) right click on the tab to close, but *within* the bar mentioned in 2.

4) pick "close tab" from the popup menu, and the wrong tab will close.

toorffej@yahoo.com
Which skin are you using? I've tried to reproduce this in both classic and
modern and can't.
I also can reproduce the bug using the steps of comment 22, using win98, build
2002070308, modern theme.
In the JS console the following error appears:
Error: uncaught exception: [Exception... "Index or size is negative or greater
than the allowed amount"  code: "1" nsresult: "0x80530001
(NS_ERROR_DOM_INDEX_SIZE_ERR)"  location:
"chrome://global/content/bindings/tabbrowser.xml#tabbrowser.removeTab() Line: 30"]
(see bug 124400)
The fix for this is pretty simple. removeTab and removeAllTabsBut currently
check to see if the node clicked on was "tabs" and if so act on the current tab.
This means that context clicks on the "new tab" button, the "close tab" button,
and that small strip below the tabs, don't act on the current tab. The check
should be to see if the node's name is "tab" and if not use the current tab.

With that fixed, there's a small problem. If your aim is a little off and you
accidentily right-click on that small strip below an inactive tab to e.g. close
it, you'll end up closing the active tab. One solution here is to disable the
context menu for that small strip, but this means that the active tab has a
small dead area.

  

  



    
    

    
  


  

  

  



        Attachment #90621 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 90658 [details] [diff] [review]
Use current tab when click wasn't on a tab

r=caillon

  

  



        Attachment #90658 -
        Flags: review+

    
    

    
  
Alfonso, can you apply my patch and see if this fixes the problem for you?

  

  



    
    

    
  
Well, I have no experience at all patching Mozilla but I've found the .xml file,
applied the changes and now the bug is gone.

  

  



    
    

    
  
*** Bug 156462 has been marked as a duplicate of this bug. ***

  

  



    
    

    
  
Comment on attachment 90658 [details] [diff] [review]
Use current tab when click wasn't on a tab

sr=ben@netscape.com

  

  



        Attachment #90658 -
        Flags: superreview+

    
    

    
  
Comment on attachment 90658 [details] [diff] [review]
Use current tab when click wasn't on a tab

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

  

  



        Attachment #90658 -
        Flags: approval+

    
    

    
  
Checked in on trunk.

  

  


Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
vrfy'd fixed using 2002.09.16 comm trunk bits.

  

  


Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 195182 has been marked as a duplicate of this bug. ***

  

  


Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: