Closed Bug 107855 Opened 23 years ago Closed 9 years ago

Only one profile can be migrated

Categories

(Core Graveyard :: Profile: Migration, defect)

x86
All
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED INCOMPLETE
Future

People

(Reporter: jesup, Assigned: ccarlen)

Details

nsPrefMigration.cpp in ProfileMigrationController() uses |index| to access the array of profiles to migrate - but it never bumps index. Thus, I imagine, only one profile can be migrated. Analysis from inspection.
-> Profile Migration
Assignee: sgehani → racham
Component: Preferences → Profile Migration
QA Contact: sairuh → ktrina
Only one profile can be migrated at a time. You may return to Profile Manager and select a second profile to migrate. Is this RFE- migrate more than one profile at a time?
Well, then the code is strangely written, since it works to create an array of profiles to migrate, then ignores all but the first one. In any case, there's something wrong with the code. Dropping severity.
Severity: normal → minor
Randell, thanks for bringing up the point. Once upon a time, there was a plan to do migration of all 4.x profiles at a time and that idea/plan lived for short time. Now that we either automigrate in case of single profile (for mozilla we ask the user instead of automigrating) OR present a choice to the user incase of multiple profiles, we should probably cleanup that portion of the code to do the obvious i.e., just to migrate the single 4.x profile. Reassinging this to Conrad as the code corresponding sits in ProfileManager. Conrad, if you do not have cycles, please do reassign it to me. thanks.
Assignee: racham → ccarlen
It's a small job, but since just code cleanup, putting off to 1.0.1.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
Pushing off this sort of thing.
Target Milestone: mozilla1.0.1 → Future
QA Contact: ktrina → profile-migration
This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE. If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.
No longer blocks: 1243899
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.