Closed
Bug 1078640
Opened 10 years ago
Closed 10 years ago
"Couldn't load XPCOM" error when launching Firefox via ./firefox from Contents/MacOS in Terminal
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
BinaryPath.h fails to sanitize the path when a user launches Firefox as follows:
1. In Terminal, cd to Contents/MacOS
2. Run ./firefox
This is due to the fact that BinaryPath::Get does not sanitize the path on OSX. The returned path in this scenario would be:
Contents/MacOS/./firefox
XPCOMGlueLoad would then manipulate this path to find the dependentlibs.list file as follows:
1. Remove executable from path: Contents/MacOS/.
2. Remove last path component: Contents/MacOS
3. Add 'Resources' path component: Contents/MacOS/Resources
The resulting path should have been Contents/Resources. The above path will fail and result in a "Couldn't load XPCOM" error.
Assignee | ||
Comment 1•10 years ago
|
||
Note that this used to work before the v2 signature changes because all files were in the same directory (Contents/MacOS), so a path of Contents/MacOS/./dependentlibs.list used to work.
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8500601 -
Flags: review?(smichaud)
Comment 3•10 years ago
|
||
Comment on attachment 8500601 [details] [diff] [review]
Patch
Looks fine to me.
Attachment #8500601 -
Flags: review?(smichaud) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/f4c31beca62b
Inbound and fx-team is currently closed. Setting checkin-needed just in case.
Keywords: checkin-needed
Assignee | ||
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 7•10 years ago
|
||
This change introduced a serious regression for me, as now I can't start firefox at all. see bug 1079655
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•