Closed Bug 1079138 Opened 10 years ago Closed 10 years ago

"DEBUG=1 make" doesn't work on ubuntu 12.04 x64

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S7 (24Oct)

People

(Reporter: lchang, Assigned: ochameau)

References

Details

Attachments

(2 files)

Attached file build script log (deleted) —
After Bug 1002545 landed [1], the building process gets stuck when I try to run "DEBUG=1 make". Please refer to the attachment for the logs. [1] https://github.com/mozilla-b2g/gaia/commit/529298abcf6eec7788dcab6d9932824e8bf4ad68
As Alexandre mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1002545#c91. It seems a problem in download.jsm. We could replace it by old one to solve this problem. Maybe Alexandre could help with us replace Downloads.jsm usage with saveURI.
Flags: needinfo?(poirot.alex)
Another question is I still have no idea why the download.jsm caused failures on ubuntu12.04 but passed on ubuntu14.04.
Attached file Pull request 24949 (deleted) —
I just tested download additional extensions and it seems to work just fine. Ricky, could you test this patch against svoperapps? It is also using download-manager and I would like to ensure it also keep working fine. I'm wondering if the usage of Downloads.jsm relates to the various exceptions about nsHandlerService.js:120 we can see when building gaia, as well as the intermittent stack reported in bug 1070622. If that's the case that would be a great win!
Attachment #8501780 - Flags: feedback?(ricky060709)
Flags: needinfo?(poirot.alex)
Nice! Luke, do you want to give it a try on your ubuntu12.04?
Flags: needinfo?(lchang)
Cool! That patch works. Thanks a lot.
Flags: needinfo?(lchang)
Comment on attachment 8501780 [details] Pull request 24949 Patch works properly for me and I didn't see those strange logs from bug 1070622.
Attachment #8501780 - Flags: feedback?(ricky060709) → feedback+
Comment on attachment 8501780 [details] Pull request 24949 Fixed some issue reported by the linter. Given the positive feedback, I think we can move forward with this patch. It may also fix bug 1070622.
Attachment #8501780 - Flags: review?(gduan)
Assignee: nobody → poirot.alex
Comment on attachment 8501780 [details] Pull request 24949 Basically, it looks fine. Just one question left in github.
Attachment #8501780 - Flags: review?(gduan) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: