Closed
Bug 1079629
Opened 10 years ago
Closed 10 years ago
Android builds are going to burn when Gecko 35 merges to Beta
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(firefox35 verified, fennec35+)
VERIFIED
FIXED
mozilla35
People
(Reporter: RyanVM, Assigned: lucasr)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2282111&repo=try
/builds/slave/try-and-0000000000000000000000/build/mobile/android/base/resources/values-large-v11/styles.xml:36: error: Error: No resource found that matches the given name (at 'android:background' with value '@drawable/new_tablet_url_bar_nav_button').
Comment 1•10 years ago
|
||
This is presumably due to Bug 1065494.
We routinely have a go/no-go meeting about Nightly features in early Aurora, so I expect this to be routinely handled, but thanks for giving us a bug to address prior to the merge!
Assigning to Lucas to make sure this gets tracked.
Status: NEW → ASSIGNED
tracking-fennec: --- → 35+
Component: General → Build Config & IDE Support
Hardware: ARM → All
Reporter | ||
Comment 2•10 years ago
|
||
This blocks me from seeing any other potential Android test failures lurking behind the build failures, so a fix sooner rather than later would be appreciated :)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → lucasr.at.mozilla
Assignee | ||
Comment 3•10 years ago
|
||
What's different about beta what is triggering this? Are Beta builds using the min/max SDK build flags?
Flags: needinfo?(rnewman)
Comment 4•10 years ago
|
||
Beta doesn't have newtablet turned on, because it's not a PRERELEASE channel. It's not SDK-ranged.
As far as I can tell from the situation, this is just straight-up bustage. Try disabling newtablet and do a build?
Flags: needinfo?(rnewman)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8502029 [details] [diff] [review]
Fix build error when new tablet UI is disabled (r=rnewman)
Some recent patches for new tablet UI didn't include the necessary drawable stubs for when the new UI is disabled at build time.
Attachment #8502029 -
Flags: review?(rnewman)
Updated•10 years ago
|
Attachment #8502029 -
Flags: review?(rnewman) → review+
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Reporter | ||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 35 → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•