Closed Bug 1080488 Opened 10 years ago Closed 7 years ago

Canvas paints do not generate paint markers (OSX)

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

All
macOS
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: paul, Unassigned)

References

Details

(Whiteboard: [devtools-platform])

http://animatron.com This web page is made of SVG animations, and we see no paint markers.
Blocks: timeline
I definitely do see paint markers with that site today. I'm not sure if the site changed or if there was a fix.
I see markers on Linux, I don't see markers on Mac. Benoit, for SVG animations, do we use different code paths on Linux and Mac?
Flags: needinfo?(bgirard)
The one tell off is turning on paint flashing. If you see content change and it's not paint flashing it's not going through the normal rendering path. In this case we're not paint flashing. Keeping needinfo, I'll have a check today to see what code path we're hitting.
Ahh, I assumed this was using SVG but its using canvas on mac. We don't instrument canvas painting. The cost for non-gpu-accelerated canvas (like on mac, subset of windows) is all done synchronously on the main thread when the paint commands are issued from js. The paint time will be under the script executing. Not sure why things are different on linux.
Flags: needinfo?(bgirard)
So… not sure why I thought it was SVG at first. I think animatron was promoted as a SVG library or something. Anyway. Paint flashing and timeline work on Linux, not on Mac. I haven't tested on Windows yet.
Summary: [timeline] Missing paint markers when recording animatron.com (SVG animations?) → [timeline] Missing paint markers when recording animatron.com (on Mac)
Moving into the Profiler component. Filter on GUTHRIE'S WAVY CAKES.
Component: Developer Tools: Timeline → Developer Tools: Profiler
OS: All → Mac OS X
Hardware: x86_64 → All
Summary: [timeline] Missing paint markers when recording animatron.com (on Mac) → Missing paint markers when recording animatron.com (on Mac)
Summary: Missing paint markers when recording animatron.com (on Mac) → Canvas paints do not generate paint markers (OSX)
Whiteboard: [devtools-platform]
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
I'm having trouble understanding the STR on this, and we are moving away from DocShell markers. If this is still an issue we should re-open under the Gecko Profiler component.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.