Closed
Bug 1080785
Opened 10 years ago
Closed 10 years ago
Enable xpinstall tests in e10s
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: mossop, Assigned: mossop)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Currently they are completely disabled but many of them appear to work and there are probably common problems for the ones that don't. Enable the ones that work and either fix or file specific bugs on the ones that don't.
Flags: qe-verify-
Flags: firefox-backlog+
Updated•10 years ago
|
Points: --- → 2
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Assignee | ||
Comment 1•10 years ago
|
||
So this is a good first step. Mostly simple fixes that gets the majority of the tests working. In some cases we were relying on executeSoon to allow callbacks to be called so now we wait for specific events from content. All other test failures look warrant their own bugs.
Attachment #8507175 -
Flags: review?(bmcbride)
Comment 2•10 years ago
|
||
Comment on attachment 8507175 [details] [diff] [review]
patch
Review of attachment 8507175 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/mozapps/extensions/test/xpinstall/browser_enabled.js
@@ +6,5 @@
> gBrowser.selectedTab = gBrowser.addTab();
> gBrowser.selectedBrowser.addEventListener("load", function() {
> gBrowser.selectedBrowser.removeEventListener("load", arguments.callee, true);
> + gBrowser.contentWindow.addEventListener("PageLoaded", function() {
> + gBrowser.contentWindow.removeEventListener("PageLoaded", arguments.callee, false);
We shouldn't be adding new usage of arguments.callee - name the listener instead. Few other cases of this in the patch to fix up.
Attachment #8507175 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•