Closed
Bug 1080922
Opened 10 years ago
Closed 10 years ago
Conformance mochitests don't report subtest results to the mochitest runner
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
u480271
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
This makes it harder to identify what failed from Try logs.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8502874 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 2•10 years ago
|
||
No review for this patch, since it's just regenerating files.
Assignee | ||
Comment 3•10 years ago
|
||
This should make it easier to run just conformance on just non-conformance tests via `mach mochitest-plain dom/canvas/test/webgl-{conformance,mochitests}`.
Attachment #8502878 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8502874 [details] [diff] [review]
0001-Add-subtest-logging-to-mochi-single.html.patch
Review of attachment 8502874 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/test/webgl-conformance/mochi-single.html
@@ +180,4 @@
>
> + gExpectFailures = false;
> + if (gTestPath in GetExpectedTestFailSet())
> + gExpectFailures = true;
gExpectFailures = (gTestPath in GetExpectedTestFailSet()), yeah?
Attachment #8502874 -
Flags: review?(dglastonbury) → review+
Attachment #8502878 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Found during this try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6d9338797a70
Attachment #8502933 -
Flags: review?(dglastonbury)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Dan Glastonbury :djg :kamidphish from comment #5)
> Comment on attachment 8502874 [details] [diff] [review]
> 0001-Add-subtest-logging-to-mochi-single.html.patch
>
> Review of attachment 8502874 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: dom/canvas/test/webgl-conformance/mochi-single.html
> @@ +180,4 @@
> >
> > + gExpectFailures = false;
> > + if (gTestPath in GetExpectedTestFailSet())
> > + gExpectFailures = true;
>
> gExpectFailures = (gTestPath in GetExpectedTestFailSet()), yeah?
I suppose.
Assignee | ||
Comment 8•10 years ago
|
||
r=kamidphish
Attachment #8502874 -
Attachment is obsolete: true
Attachment #8502935 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
Comment on attachment 8502933 [details] [diff] [review]
0004-Stop-logging-from-fixed-bug-763355.patch
Review of attachment 8502933 [details] [diff] [review]:
-----------------------------------------------------------------
Did you find out why the failures happen?
Attachment #8502933 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 11•10 years ago
|
||
(In reply to Dan Glastonbury :djg :kamidphish from comment #10)
> Comment on attachment 8502933 [details] [diff] [review]
> 0004-Stop-logging-from-fixed-bug-763355.patch
>
> Review of attachment 8502933 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Did you find out why the failures happen?
Yeah, we clearly call testPassed() after finish() in the logging that patch removed. It seems like the looser coupling we had before allowed this to go undetected.
Assignee | ||
Comment 12•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0617afd9199
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9652f8a8c37b
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/94a4181b0a4a
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/441b42b81251
https://hg.mozilla.org/mozilla-central/rev/d0617afd9199
https://hg.mozilla.org/mozilla-central/rev/9652f8a8c37b
https://hg.mozilla.org/mozilla-central/rev/94a4181b0a4a
https://hg.mozilla.org/mozilla-central/rev/441b42b81251
https://hg.mozilla.org/mozilla-central/rev/a1e44f48ddbd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 14•10 years ago
|
||
Filed bug 1102402 for intermittent issue on test_conformance__canvas__buffer-offscreen-test.html
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•