ASAN on Windows now supports -MD, which means that the fix to bug 1036215 needs to be tweaked to not mark these functions as dllexport. Currently, we get: 5:40.89 ../dist/include/mozilla/MemoryChecking.h(44,1) : error(clang): redeclaration of '__asan_poison_memory_region' cannot add 'dllexport' attribute 5:40.89 __asan_poison_memory_region(void const volatile *addr, size_t size); 5:40.89 ^ 5:40.89 c:/moz/fallback/obj-ff-asan/dist/include/nspr\plarena.h(102,6) : note(clang): previous declaration is here 5:40.89 void __asan_poison_memory_region(void const volatile *addr, size_t size); 5:40.89 ^

Comment on attachment 8502923 [details] [diff] [review] Don't mark ASAN poisoning functions as dllexport on Windows; r=njn Review of attachment 8502923 [details] [diff] [review]: ----------------------------------------------------------------- r=me if it builds! :)