Closed
Bug 1080947
Opened 10 years ago
Closed 10 years ago
UITour: tell the page when a Hello room view opens or closes
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: Dolske, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
The Hello tour needs to know when a room view ("conversation") is opened or closed:
* After guiding the user to click "New Room", we want to then point to the room view and ask them to click Email/Copy Link.
* If the user closes the view instead of sharing a link, we want to adjust the tour (so it's not pointing at a non-existent view)
* At the end of a successful conversation, we'd like to know they're done.
Note that it's possible for a user to create multiple rooms (and close them!).
The backend of this should probably involve Hello using existing message passing mechanisms to tell chrome (UITour) that a view was opened/closed, and then UITour can notify any existing tour pages. API TBD -- probably want the page to explicitly opt-in to receiving notifications/callbacks, but we could also just create and fire DOM events at the tour page.
Some possible overlap with bug 1080944 -- the open notification could include the size/position of the room view.
Reporter | ||
Updated•10 years ago
|
Blocks: fx-UITour-Hello
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8532332 -
Flags: review?(standard8)
Attachment #8532332 -
Flags: review?(bmcbride)
Assignee | ||
Comment 2•10 years ago
|
||
/r/1155 - Bug 1080947 - UITour: tell the page when a Hello chat window opens or closes. r=Standard8
Pull down this commit:
hg pull review -r 396d3507485be897160c9c79163317d185e13a86
Updated•10 years ago
|
Attachment #8532332 -
Flags: review?(bmcbride) → review+
Comment 3•10 years ago
|
||
https://reviewboard.mozilla.org/r/1153/#review669
r+ on the parts I know anything about (ie, not including Loop)
::: browser/components/loop/MozLoopService.jsm
(Diff revision 1)
> + UITour.notify("LoopChatWindowClosed");
My preference would be to namespace these event names, to help add organisation/structure.
So something like "Loop:ChatWindowClosed"
Assignee | ||
Updated•10 years ago
|
Attachment #8532332 -
Flags: review+ → review?(bmcbride)
Assignee | ||
Comment 4•10 years ago
|
||
/r/1155 - Bug 1080947 - UITour: tell the page when a Hello chat window opens or closes. r=Standard8,Unfocused
Pull down this commit:
hg pull review -r bf99280c56242476b2aab3ac73acc98951c2091f
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 37.1
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
https://reviewboard.mozilla.org/r/1153/#review681
::: browser/components/loop/MozLoopService.jsm
(Diff revision 2)
> + chatbox.contentWindow.addEventListener("unload", function onUnloadChat(evt) {
> + UITour.notify("Loop:ChatWindowClosed");
> + });
> +
> let window = chatbox.contentWindow;
Move 'let window = ...' to above the addEventListener line.
Updated•10 years ago
|
Attachment #8532332 -
Flags: review?(standard8) → review+
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
Flags: in-testsuite+
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•10 years ago
|
Attachment #8532332 -
Flags: review?(bmcbride)
Assignee | ||
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8532332 [details]
MozReview Request: bz://1080947/MattN
[Triage Comment]
Needed for Fx35 Hello tour, no unusual risk.
Attachment #8532332 -
Flags: approval-mozilla-beta+
Attachment #8532332 -
Flags: approval-mozilla-aurora+
Comment 10•10 years ago
|
||
Updated•10 years ago
|
Assignee | ||
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8532332 -
Attachment is obsolete: true
Attachment #8618401 -
Flags: review+
Assignee | ||
Comment 13•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•