Closed
Bug 1080994
Opened 10 years ago
Closed 10 years ago
Build libclearkey without a dependency on mozalloc or mozglue
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
patch
|
keeler
:
review+
cpearce
:
review+
|
Details | Diff | Splinter Review |
Tell me if I'm wrong, but I don't see a compelling reason for libclearkey to depend on either mozalloc or mozglue. I doubt other gmp plugins would depend on them. The one fishy thing resulting from this is that its memory allocations wouldn't go through jemalloc on windows, but so would those from 3rd party gmp plugins, which brings up the case of changing how we hook memory allocation, but that would be a separate bug.
Assignee | ||
Comment 1•10 years ago
|
||
> its memory allocations wouldn't go through jemalloc on windows
well, it doesn't look like it's doing any allocation of its own...
Assignee | ||
Comment 2•10 years ago
|
||
dkeeler for ScopedNSSTypes.h.
cpearce for the dependency change itself.
Attachment #8502983 -
Flags: review?(dkeeler)
Attachment #8502983 -
Flags: review?(cpearce)
Comment on attachment 8502983 [details] [diff] [review]
Build libclearkey without a dependency on mozalloc or mozglue
Review of attachment 8502983 [details] [diff] [review]:
-----------------------------------------------------------------
r=me for PSM changes.
::: security/manager/ssl/src/ScopedNSSTypes.h
@@ +263,2 @@
> mozalloc_handle_oom(len);
> + if (MOZ_UNLIKELY(!SECITEM_AllocItem(nullptr, &item, len)))
Honestly, I'm not entirely sure why we have this. We may be able to get rid of this wrapper entirely, but until someone takes the effort to figure that out, this is fine.
Attachment #8502983 -
Flags: review?(dkeeler) → review+
Updated•10 years ago
|
Attachment #8502983 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•