Closed
Bug 1081018
Opened 10 years ago
Closed 10 years ago
Stop calling consumer_info if we already have the region
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-10-21
People
(Reporter: mat, Assigned: mat)
References
Details
(Keywords: perf, Whiteboard: [repoman])
Before we started putting more stuff (fxa settings, waffles etc) in consumer_info we used to be able not to call it at all if we already have the region from the SIM. Kevin removed the extra stuff in bug 1038936 so we should be able to do that again now, improving performance. As a bonus, we should also make sure the site config endpoint is called anonymously using the CDN.
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → 2014-10-21
Assignee | ||
Comment 1•10 years ago
|
||
Fixed in https://github.com/mozilla/fireplace/commit/5f972a0d2846ab5ec221f5897c3b0af1ba11f7ab STR: - Load marketplace from a phone with a SIM from a supported region - With either ashes or WebIDE console, check that no request is made to /api/v2/fireplace/consumer_info/ - Check that the region is correct
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 2•10 years ago
|
||
I don't have access to ashes. Can you please verify these ashes db645 ?
Assignee | ||
Comment 3•10 years ago
|
||
Verified, there is no call to consumer_info in those ashes logs because the SIM already gives region=es.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•