Andrew McCreight [:mccr8] Reporter
	Description • 10 years ago

Running locally, I'm hitting the assertion MOZ_ASSERT(swm) in this method.  Is that expected?  This is just running e10s mochitests with some patches that keep us from crashing in shutdown.  IIRC, this was happening inside the shutdown CC.  I just changed the assert to a null check and it seems okay.

	Andrea Marchesini [:baku]
	Comment 2 • 10 years ago

Comment on attachment 8553927 [details] [diff] [review]
Silently ignore lack of ServiceWorkerManager when shutting down ServiceWorkerContainer

Review of attachment 8553927 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerContainer.cpp
@@ +55,5 @@
>    nsCOMPtr<nsPIDOMWindow> window = GetOwner();
>    if (window) {
>      nsCOMPtr<nsIServiceWorkerManager> swm =
>        mozilla::services::GetServiceWorkerManager();
> +    if (!swm) {

Maybe just write a comment...

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?) Assignee
	Comment 3 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d924b6797f

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/e3d924b6797f