Closed
Bug 1081293
Opened 10 years ago
Closed 10 years ago
Assertion failure in ServiceWorkerContainer::RemoveReadyPromise()
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: mccr8, Assigned: nsm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Running locally, I'm hitting the assertion MOZ_ASSERT(swm) in this method. Is that expected? This is just running e10s mochitests with some patches that keep us from crashing in shutdown. IIRC, this was happening inside the shutdown CC. I just changed the assert to a null check and it seems okay.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8553927 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8553927 [details] [diff] [review]
Silently ignore lack of ServiceWorkerManager when shutting down ServiceWorkerContainer
Review of attachment 8553927 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/workers/ServiceWorkerContainer.cpp
@@ +55,5 @@
> nsCOMPtr<nsPIDOMWindow> window = GetOwner();
> if (window) {
> nsCOMPtr<nsIServiceWorkerManager> swm =
> mozilla::services::GetServiceWorkerManager();
> + if (!swm) {
Maybe just write a comment...
Attachment #8553927 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•