Closed
Bug 1081407
Opened 10 years ago
Closed 10 years ago
Statusbar icons still broken in landscape mode
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P1)
Tracking
(tracking-b2g:backlog)
People
(Reporter: gwagner, Assigned: gmarty)
Details
(Whiteboard: [systemsfe])
Attachments
(3 files)
broken
on 2.1:
When enough icons are enabled, we seem to hide the wrong ones first. I assume the network icon has high priority.
|
Reporter | |
Comment 1•10 years ago
|
||
|
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [systemsfe]
|
|
Reporter | |
Comment 2•10 years ago
|
||
Hard to get to get so many icons on the status bar so not blocking on it.
blocking-b2g: --- → backlog
Priority: -- → P1
|
Assignee | |
Comment 3•10 years ago
|
||
I can reproduce, the SHB needs to be on.
There is a styling issue that forces the SIM card 1 icon to wrap on a new line, underneath the SIM card 2.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → gmarty
|
|
Assignee | |
Comment 4•10 years ago
|
||
The patch takes the SHB width into consideration on landscape mode.
Etienne or Vivien, can any of you have a look please? I added unit tests before you ask :-)
Attachment #8504092 -
Flags: review?(etienne)
Attachment #8504092 -
Flags: review?(21)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8504092 [details]
Github PR
r- because I think we can reuse one of the SHB method. Let me know if I'm wrong.
Attachment #8504092 -
Flags: review?(21) → review-
|
|
Assignee | |
Updated•10 years ago
|
Target Milestone: --- → 2.1 S7 (Oct24)
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8504092 [details]
Github PR
Even less code, can we use layoutManager.width?
https://github.com/mozilla-b2g/gaia/blob/ba6667c83c5d0fb1e333349dfeaf5f6ca8043e63/apps/system/js/layout_manager.js#L74
Attachment #8504092 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 7•10 years ago
|
||
This bug is going to be fixed in Bug 1082667.
|
||
Comment 8•10 years ago
|
||
(In reply to Guillaume Marty [:gmarty] from comment #7)
> This bug is going to be fixed in Bug 1082667.
Should we mark this a duplicate of bug 1082667 then?
Flags: needinfo?(gmarty)
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(gmarty)
Resolution: --- → DUPLICATE
|
||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•