All modals in gaia should follow the same background colors as the attached capture confirm.png Now, action menus, object menus and modals triggered from system don't share the same styles.

Comment on attachment 8503614 [details] patch in github just few nits on github

Thanks Pavel for this quick review ;) I've fixed your comments. I'll wait for ui-review before merging.

Comment on attachment 8503613 [details] after_patch.png Thanks. Looks correct with the transparency gone.

Merged: https://github.com/mozilla-b2g/gaia/commit/e81582af8aaccf2af41c0642478caf4a8cc42c8a

A consistent visual design is paramount for user perceived quality.

Duane, please verify that this issue is fixed.

Issue is verified fixed in Flame 2.2 (Full Flash, nightly). Actual Results: Visuals for various UI screens have the same format (no transparency, etc.). Device: Flame Master Build ID: 20141016040204 Gaia: 841d0d7d1b879f0ff4b5a8727f5dd23c7b0000a9 Gecko: a280a03c9f3c Version: 36.0a1 (Master) Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 ------------------------------------------------------------------------------- ------------------------------------------------------------------------------- Issue DOES occur in latest Flame 2.1 build (Full Flash, nightly). Actual Results: Visuals for the multiple screens do NOT have the same format (illustrated in 'incorrect-modals.png' attachment above). Device: Flame 2.1 Build ID: 20141016001201 Gaia: 477a9e61c3edf12f32a62a19d329cd277202cc6b Gecko: 67573e422a0f Version: 34.0 (2.1) Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Arnau, can you comment on how risk this change is ? Given where we are in 2.1 I do not want to surface regressions from landings we could avoid and may not be worth the reward at this point in the release cycle. So, you input on 2.1 uplift will help here given the partner interest of fixing this.

There's no risk in the uplift, this patch is only changing styles in modals, without affecting the functionality. For 2.1 we only changed one of the three modal types we have in the system, so this patch is for visual consistency.

Adding verifyme for 2.1 verification once the patch has been uplifted.

Please request Gaia v2.1 approval on this patch when you get a chance :)

Comment on attachment 8503614 [details] patch in github [Approval Request Comment] [Bug caused by] (feature/regressing bug #): outdated visual design [User impact] if declined: Inconsistent UI [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): no risk [String changes made]:

v2.1: https://github.com/mozilla-b2g/gaia/commit/2b6584b9acbc9e7f1cf8886890704df65a78a1c1

Issue verified as fixed in Flame 2.1 Actual Result: Visuals for various UI screens have the same format (no transparency, etc.). Device: Flame 2.1 BuildID: 20141023001201 Gaia: 0f76e0baac733cca56d0140e954c5f446ebc061f Gecko: 09fb60a37850 Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d Version: 34.0 (2.1) Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0