Closed Bug 1081537 Opened 10 years ago Closed 10 years ago

"Update Scanner" add-on does not work on Nightly

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Version:
35 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed

People

(Reporter: alice0775, Assigned: bholley)

References

Details

(Keywords: regression)

Attachments

(2 files)

Fall back to the addon global (if one exists) in GetEntryDocument. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
Tests. v1
(deleted), patch
bzbarsky
: review+
Details | Diff | Splinter Review
[Tracking Requested - why for this release]: Steps To Reproduce: 1. Install https://addons.mozilla.org/ja/firefox/addon/update-scanner/ 2. Open View – Sidebar – Update Scanner (Alt+U) 3. Add new entry and click the entry Actual Results: No web content appears An error shown in Error console: SecurityError: The operation is insecure. diffPage.js:180 Expected Results: web content appears Regression window(m-i) Good: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e25cd3e8219 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140924000252 Bad: https://hg.mozilla.org/integration/mozilla-inbound/rev/35dcddea2c7a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20140924001753 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1e25cd3e8219&tochange=35dcddea2c7a Suspected: Bug 1030420
Summary: Update Scanner does not work Nightly35.0a1 → "Update Scanner" add-on does not work Nightly35.0a1
Summary: "Update Scanner" add-on does not work Nightly35.0a1 → "Update Scanner" add-on does not work on Nightly35.0a1
Setting user_pref("dom.compartment_per_addon", false) fixes the problem
This fixes the problem for me.
Attachment #8504886 - Flags: review?(bzbarsky)
Assignee: nobody → bobbyholley
Comment on attachment 8504886 [details] [diff] [review] Fall back to the addon global (if one exists) in GetEntryDocument. v1 r=me. How easy is a test?
Attachment #8504886 - Flags: review?(bzbarsky) → review+
Attached patch Tests. v1 (deleted) — — Splinter Review
Attachment #8506984 - Flags: review?(bzbarsky)
Comment on attachment 8506984 [details] [diff] [review] Tests. v1 r=me
Attachment #8506984 - Flags: review?(bzbarsky) → review+
looks like this needs: if (!entryWin && global) {
Flags: needinfo?(bobbyholley)
(In reply to Bob Owen (:bobowen) from comment #7) > looks like this needs: > if (!entryWin && global) { Whoops. Pushed a followup fix for the bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/5bd3640ea381
Flags: needinfo?(bobbyholley)
Looks like we need uplift here, please nominate for Aurora.
status-firefox36: --- → fixed
tracking-firefox35: ? → +
Flags: needinfo?(bobbyholley)
(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #10) > Looks like we need uplift here, please nominate for Aurora. This feature is behind NIGHTLY_BUILD, so it shouldn't be enabled on Aurora.
Flags: needinfo?(bobbyholley)
Summary: "Update Scanner" add-on does not work on Nightly35.0a1 → "Update Scanner" add-on does not work on Nightly
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: