Closed Bug 1081689 Opened 10 years ago Closed 10 years ago

Allow unregistration of a protocol.js type

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file)

remove-type.diff
(deleted), patch
paul
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch remove-type.diff (deleted) — — Splinter Review 
The attached patch allows a type to be unregistered after adding it.
Assignee: wbamberg → nobody
Product: Developer Documentation → Firefox
Attachment #8503774 - Flags: review?(paul)
Attachment #8503774 - Flags: review?(paul) → review+
Dave, is this ready to land?
Flags: needinfo?(dcamp)
Yes.
Flags: needinfo?(dcamp)
https://hg.mozilla.org/mozilla-central/rev/2df5473a8fbb
Assignee: nobody → dcamp
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Comment on attachment 8503774 [details] [diff] [review]
remove-type.diff

Approval Request Comment
[Feature/regressing bug #]: Tweaked behaviour to support bug 1054363 (available as add-on)
[User impact if declined]: DevEdition won't support 3rd party browsers
[Describe test coverage new/current, TBPL]: gum, fx-team, m-c
[Risks and why]: Some risk to RDP used by developer tools, but test coverage is good for this code
[String/UUID change made/needed]: none
Attachment #8503774 - Flags: approval-mozilla-aurora?
Attachment #8503774 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: