Closed
Bug 1082314
Opened 10 years ago
Closed 9 years ago
define PSAPI_VERSION 1 to support xp.
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: c, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.4; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141012225757
Reporter | ||
Comment 1•10 years ago
|
||
Why is this required? What happens if you don't include it? I've been compiling and running VS2013 builds on XP successfully for some time.
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to David Major [:dmajor] (UTC+13) from comment #2)
> Why is this required? What happens if you don't include it? I've been
> compiling and running VS2013 builds on XP successfully for some time.
I put WinMouseScrollHandler.cpp into unified building, which uses GetProcessImageFileName function, then I ran into issues with xp.
http://msdn.microsoft.com/en-us/library/ms683217%28VS.85%29.aspx
I thought it's a better idea to define it just in case.
I see. I had just landed the compiler change on mozilla-inbound a few minutes before you filed this bug. It doesn't sound like a reason for a backout, we can fix this as a followup.
Just to be sure, I tested the very first VS2013 tinderbox build: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1413255361/ It loads fine on XP (even SP2).
Comment 6•9 years ago
|
||
WFM as per comment 5.
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Component: General → Build Config
Resolution: --- → WORKSFORME
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•